Repository navigation
Conversation
10 tasks done
Contributor
Author
|
Closing this duplicate: it carries the same Windows O_RDONLY|O_TRUNC fix already reviewed in #5112. The maintainer closed #5112 because no title-specific failure was identified and asked contributors to hold generic PRs while the queue is high. I should have found that history before opening this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5095.
What
On Windows,
CreateFileWrejectsTRUNCATE_EXISTINGwithGENERIC_READalone, soopen(path, O_RDONLY | O_TRUNC)fails instead of truncating. For that flag combination, open with the access needed to truncate, then narrow the resulting handle to read-only. This matches the FreeBSD/Linux behavior while keeping the guest descriptor read-only. The implementation records the remaining Windows host sharing difference in technical debt.The three commits carry David’s implementation, regression, and debt update with his original commit authorship preserved.
Tested
guest_filesystemandguest_kernel_fcntlpassed (2/2).tools/check_conventions.py --base upstream/mainpassed.Checklist
main; no other open PR implements the same functions