Repository navigation
Conversation
|
Thanks. The NID recomputes (nya-R5gDYhM is sceAudioInHqOpen), and the two new rows go through the shared validation as described. One thing before it goes in: the claim that the HQ port differs from
Neither source is the console, so I can't say which is right. Under the exact-or-throw rule, I'd accept only what both agree on (type 0 or 1, index 0, 128 samples at 48000 Hz, the same params), throw for 256 samples and 16000 Hz on the HQ path, and add a line under "Unknown function info" in docs/dev/TechnicalDebt.md saying that an HQ port captures with the same blocking cadence as Small one: a param of 0x10 now reaches For context, PPSA21564 imports |
|
Are you still working on this? The points from 10-04 are still open:
PPSA21564 imports |
sceAudioInHqOpen was a throwing stub. It takes the same parameters as sceAudioInOpen and opens an input port the same way; the "Hq" variant only differs by the high-quality formats it accepts, which sceAudioInOpen already validates. It now forwards to sceAudioInOpen, as it does in shadPS4. Extends the existing guest_audio_in validation with two sceAudioInHqOpen calls (invalid type and size) that go through the shared validation. It fails on main (the stub throws) and passes with the change.
Per review: sceAudioInHqOpen now throws for 256 samples and 16000 Hz, where shadPS4 (which forwards to sceAudioInOpen) and KytyPS5 (which accepts only 128 samples at 48000 Hz) disagree, and forwards the agreed 128/48000 format to sceAudioInOpen. A thrown report now names sceAudioInHqOpen. Records the unknown capture cadence in docs/dev/TechnicalDebt.md and updates the guest_audio_in rows to a valid HQ length.
38545f3 to
703249d
Compare
|
Done. sceAudioInHqOpen now throws (reporting its own name) for the 256-sample length and 16000 Hz that shadPS4 and KytyPS5 disagree on, and forwards the agreed 128/48000 format to sceAudioInOpen. Added an "Unknown function info" line for the capture cadence, and the guest_audio_in rows use a valid HQ length now. guest_audio_in passes here. |
|
Thanks for finishing all three points; it passed our regression runs too. One question remains, the same as on #571 and #572: which title calls |
adriadam10
left a comment
There was a problem hiding this comment.
Checked the code against the references: KytyPS5 AudioInHqOpen goes through OpenPort(..., true), shadPS4 forwards to sceAudioInOpen, and SharpProspero documents the HQ port as 48 kHz / 128-sample grain. sceAudioInOpen only accepts len 128/256 and freq 48000/16000, so the 128/48000 pair is the only one that reaches an open port and the throw for 256 / 16000 is consistent with Dean's earlier request. Two things left:
core/libs/tests/GuestAudioIn.cpp:44-45: the new rows only cover the error paths (type 2, len 512). Nothing opens an HQ port, so the forwarding itself is untested. Please add a success row (sceAudioInHqOpen(user, 0, 0, 128, 48000, 2) > 0, thensceAudioInInputreturns 128 andsceAudioInClosereturns 0), e.g. inTestNoDevice, and ideally one case per throw (256 samples, 16000 Hz) if the guest test harness can catch it.- The PR description still says it only forwards to
sceAudioInOpen; please update it with the 128/48000 restriction.
On Dean's question about the title: sceAudioInHqOpen is in the import list of Astro's Playroom (PPSA01325) as an unimplemented stub, and Dean noted PPSA21564 imports it too. If you have a log line of where either stops on main, add it to the description.
|
On which title calls it: Astro Bot (PPSA21567 v01.019.000, retail) calls The HQ call is What I can't give is a stop on Found and written by Claude (AI assistant) on a contributor's machine. |
|
Closing for now: the points from 2026-10-07 are still open. If you pick it back up, please comment here and it can be reopened. |
|
A title reaches this on With this PR's head 703249d merged onto that commit (it merges cleanly) the title gets past the call, loads |
What
sceAudioInHqOpenwas a throwing stub. It takes the same parameters assceAudioInOpenandopens an input port in the same way; the "Hq" variant only differs by the high-quality formats it
accepts, which
sceAudioInOpenalready validates. It now forwards tosceAudioInOpen, as it doesin shadPS4.
Tested
Extends the existing
guest_audio_invalidation with twosceAudioInHqOpencalls (invalid typeand invalid size) that go through the shared validation path.
Built with MinGW-w64 GCC 15.2.0 (the CI toolchain) on Windows 11;
ctest -R guest_audio_inpasses(both
guest_audio_in_captureandguest_audio_in_no_device). Onmainthe stub throwsnot implemented, so the test aborts without the change.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)