Repository navigation
docs(debt): record PPSA26344 call-site evidence - #5877
Conversation
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
adriadam10
left a comment
There was a problem hiding this comment.
Thanks for carrying this over. Points before this can merge:
- The AGC entry (
dbOlWdppb4o: three pointers at nine sites, return value not read) matches the evidence in #2355. The VideoOut (0xfwith a branch on the result equalling 1,(0xFF, 0, 0, nullptr)), Psml (*1100imported but not called, three pointers toGetDispatchMfsrPacket1100), VoiceQoS (0x40000-byte block, app type 0x10000000) and SystemService (parameter 6 with a 65-byte buffer) observations are not in #2355 or anywhere else we can check. Please add the call-site addresses and the argument-setup instructions for each, as #2355 does, in the PR body or in #2355, so they can be verified. docs/dev/debt/libScePsml_debug.mdconflicts withmain: thescePsmlMfsrEnableSpecularAA/Quality8Kentry was split out of the NID line. Please rebase and re-apply your sentence.- This depends on #5848, which renames the
dbOlWdppb4oentry; rebase after it lands and update the entry name accordingly.
|
The requested call-site evidence is now recorded in #2355: the existing nine-site AGC observations plus the exact addresses and argument setup for VideoOut, Psml, VoiceQoS, and SystemService are in the issue body/addenda. The dependency #5848 is still open, so I have not rebased this PR or changed the AGC entry name yet; I will do that once #5848 lands. |
28b726e to
f9ee00e
Compare
|
Addressed the review points and rebased this PR onto current
|
|
@adriadam10 The requested call-site addresses and argument setup are now in #2355 and in the current PR diff. The PSML entries preserve the split names, and #5848 is merged; the AGC entry uses the current name. The current head passes eligibility and conventions. Could you recheck the updated PR when convenient? |
|
Addressed the review points in |
f9ee00e to
931d209
Compare
adriadam10
left a comment
There was a problem hiding this comment.
Checked the call-site addresses and argument setups against #2355, the Psml split entry and the _10000 name on current main; docs only. Merging.
What
Records the PPSA26344 call-site observations from #2355 in the existing technical-debt entries for AGC interpolant mapping, VideoOut, PSML, VoiceQoS, and SystemService. The notes distinguish values read from the executable from unconfirmed console prototypes and behavior. No implementation or runtime behavior is inferred. Exact call-site addresses and argument setup evidence are recorded in #2355.
Tested
git diff --check upstream/mainpython3 tools/check_conventions.py --base upstream/mainChecklist
main; no other open PR implements the same change