Skip to content

docs(debt): record PPSA26344 call-site evidence - #5877

Merged
adriadam10 merged 1 commit into
boykopovar:mainfrom
MarcZX10:docs/pps26344-call-sites-2355
Oct 16, 2026
Merged

adriadam10 merged 1 commit into
boykopovar:mainfrom
MarcZX10:docs/pps26344-call-sites-2355

Conversation

@MarcZX10

@MarcZX10 MarcZX10 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

What

Records the PPSA26344 call-site observations from #2355 in the existing technical-debt entries for AGC interpolant mapping, VideoOut, PSML, VoiceQoS, and SystemService. The notes distinguish values read from the executable from unconfirmed console prototypes and behavior. No implementation or runtime behavior is inferred. Exact call-site addresses and argument setup evidence are recorded in #2355.

Tested

  • git diff --check upstream/main
  • python3 tools/check_conventions.py --base upstream/main
  • No runtime test applies to this documentation-only change.

Checklist

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.

Pull request Conflicting files (lines on main) Same exports Same new files
PR 5084 docs/dev/debt/libSceSystemService.md L14-15
PR 5796 docs/dev/debt/libScePsml_debug.md L6
PR 6026 docs/dev/debt/libSceVoiceQoS.md L6
PR 6447 docs/dev/debt/libSceSystemService.md L14

Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.

Pull request Shared files not compared
PR 4040 docs/dev/debt/libSceVideoOut.md
PR 5651 docs/dev/debt/libScePsml_debug.md
PR 6507 docs/dev/debt/libSceVideoOut.md

@adriadam10 adriadam10 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for carrying this over. Points before this can merge:

  • The AGC entry (dbOlWdppb4o: three pointers at nine sites, return value not read) matches the evidence in #2355. The VideoOut (0xf with a branch on the result equalling 1, (0xFF, 0, 0, nullptr)), Psml (*1100 imported but not called, three pointers to GetDispatchMfsrPacket1100), VoiceQoS (0x40000-byte block, app type 0x10000000) and SystemService (parameter 6 with a 65-byte buffer) observations are not in #2355 or anywhere else we can check. Please add the call-site addresses and the argument-setup instructions for each, as #2355 does, in the PR body or in #2355, so they can be verified.
  • docs/dev/debt/libScePsml_debug.md conflicts with main: the scePsmlMfsrEnableSpecularAA/Quality8K entry was split out of the NID line. Please rebase and re-apply your sentence.
  • This depends on #5848, which renames the dbOlWdppb4o entry; rebase after it lands and update the entry name accordingly.

@MarcZX10

Copy link
Copy Markdown
Contributor Author

The requested call-site evidence is now recorded in #2355: the existing nine-site AGC observations plus the exact addresses and argument setup for VideoOut, Psml, VoiceQoS, and SystemService are in the issue body/addenda. The dependency #5848 is still open, so I have not rebased this PR or changed the AGC entry name yet; I will do that once #5848 lands.

@MarcZX10
MarcZX10 force-pushed the docs/pps26344-call-sites-2355 branch from 28b726e to f9ee00e Compare October 16, 2026 05:36
@MarcZX10

Copy link
Copy Markdown
Contributor Author

Addressed the review points and rebased this PR onto current main in f9ee00ea7:

git diff --check and tools/check_conventions.py --base upstream/main pass. GitHub eligibility is queued; I’ll check its result before treating this as ready.

@github-actions github-actions Bot removed the needs rebase Conflicts with main, rebase needed label Oct 16, 2026
@MarcZX10

Copy link
Copy Markdown
Contributor Author

@adriadam10 The requested call-site addresses and argument setup are now in #2355 and in the current PR diff. The PSML entries preserve the split names, and #5848 is merged; the AGC entry uses the current name. The current head passes eligibility and conventions. Could you recheck the updated PR when convenient?

@MarcZX10

Copy link
Copy Markdown
Contributor Author

Addressed the review points in 931d20929: rebased on current main, retained the latest Psml NID split, and added the requested executable call-site addresses and argument setup to the relevant debt entries and PR description. python3 tools/check_conventions.py --base upstream/main and git diff --check upstream/main pass. The evidence remains scoped to observed title call sites; it does not claim runtime reachability or console behavior. Please re-review when convenient.

@MarcZX10
MarcZX10 force-pushed the docs/pps26344-call-sites-2355 branch from f9ee00e to 931d209 Compare October 16, 2026 17:00

@adriadam10 adriadam10 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the call-site addresses and argument setups against #2355, the Psml split entry and the _10000 name on current main; docs only. Merging.

@adriadam10
adriadam10 merged commit f26eb67 into boykopovar:main Oct 16, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants