Repository navigation
test(agc): lift the host import budget in the sparse dma-buf import test - #6261
Merged
oneandonlydean merged 1 commit intoOct 17, 2026
Merged
Conversation
The test imports ranges just above udmabuf's size limit and keeps the first one live. With size_limit_mb=8192 each range is 8257 MiB, so on a host with 32 GB of RAM the default budget (half the physical memory) refuses the second import and HostImportFor returns nullptr instead of reaching the sparse path: "a failure at UDMABUF_CREATE after the sparse path was chosen did not throw". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 15, 2026
Closed
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
agc_host_import_sparsefails onmainon a Linux host where/dev/udmabufis writable andudmabuf.size_limit_mbis raised to 8192, the setting the host import path needs for large titles:Why it fails:
RangeBytes()gives limit + 65 MiB = 8257 MiB here), and the range fromImportsALargeRangeAsOneSparseBufferstays live.HostImportForthen returnsnullptrbefore the sparse decision, so the failure cases never reach the step they test.size_limit_mbof 64 every range is 129 MiB and the test passes. Hosts without/dev/udmabufaccess skip it, which is likely why nobody reported it.The fix is one line: the test lifts the budget with
SetHostImportBudget, asBdaResourcesalready does. The budget is not what this test checks.#5390 edits other functions in this file and adds one more live import in
UnalignedOffsetStartsAtTheBlockBelow, so on the same host it hits this too. The hunks don't overlap.Tested
Based on
maindb81992. CachyOS Linux 7.2.9, GCC, RX 9070 XT (RADV Mesa 26.2.4), 32 GB RAM,udmabuf.size_limit_mb=8192,/dev/udmabufwritable:main,agc_host_import_sparsefails as shown above. It fails the same way ona050f856f, and passes there withAPS5_HOST_IMPORT_MIB=40000.host import sparse dma-buf tests passed).Not tested: other RAM sizes or the default
size_limit_mb, which needs root to change.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)Tested and written by Claude (AI assistant) on a contributor's machine.