Skip to content

feat(libSceVoice): record EnableChat/DisableChat without chat mix (PPSA34015) - #6461

Closed
notaxeltv wants to merge 1 commit into
boykopovar:mainfrom
notaxeltv:feat/libSceVoice-enable-disable-chat
Closed

notaxeltv wants to merge 1 commit into
boykopovar:mainfrom
notaxeltv:feat/libSceVoice-enable-disable-chat

Conversation

@notaxeltv

Copy link
Copy Markdown
Contributor

What

sceVoiceEnableChat / sceVoiceDisableChat were stubs that throw. After sceVoiceInit they return 0 and only record whether chat is allowed, like sceAudioOut2EnableChat / DisableChat (host mixes no chat audio). Documented under Functional debt. PPSA34015 imports them (tools/import_audit.py stub).

Tested

Windows 10, WinLibs GCC 15.2.0, guest_voice passes. tools/check_conventions.py --base upstream/main passes.

Checklist

  • Based on current main; no other open PR implements the same functions
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical debt
  • Unimplemented paths throw (NotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file
  • No notes, investigation .md files or images added to the repository (attach them to this PR)
  • New third-party code is a submodule built from source (none)
  • Generic behaviour, not specific to one title
  • Depends on: none
  • Unblocks: PPSA34015 (stub imports)
  • GPUs tested: n/a
  • AI-assisted: yes

Made with Cursor

Match AudioOut2: accept parameterless toggles after init; host mixes no chat.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

Copy link
Copy Markdown

Progress report (0029e62 → 60ed200)

📈 System libraries: 88.85% (+0.05%, +2 implemented functions)

✅ 2 implemented
Library Name
libSceVoice sceVoiceDisableChat
libSceVoice sceVoiceEnableChat

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.

Pull request Shared files not compared
PR 6044 core/libs/tests/GuestVoice.cpp
PR 7566 core/libs/prx/libSceVoice/Export.cpp
core/libs/tests/GuestVoice.cpp
docs/dev/debt/libSceVoice.md

@coltken95

Copy link
Copy Markdown

Tested on Linux x86-64 (Release build), with 60ed200 merged into main 44df216:

  • With the PR: guest_voice passes.
  • With main's libSceVoice/Export.cpp: it aborts with what(): sceVoiceEnableChat not implemented.

AI-assisted: yes (Claude Code)

@github-actions github-actions Bot added docs prx needs rebase Conflicts with main, rebase needed labels Oct 16, 2026
@blawesom

Copy link
Copy Markdown
Contributor

Rebase handoff — rebased onto current main (authorship unchanged). One docs-debt conflict, unioned.

Verified on Linux (CachyOS, kernel 7.2.9, GCC 16.2.1, Ninja, Release, BUILD_TESTING=ON, AMD RX 9070 XT / RADV):

To pick it up:

git fetch https://github.com/blawesom/AnyPS5 rebase/6461
git checkout <your branch>
git merge --ff-only FETCH_HEAD

Head is 9bb098601.

@github-actions github-actions Bot added the unblocks title Names a title ID on the Unblocks line label Oct 18, 2026
@adriadam10 adriadam10 self-assigned this Oct 19, 2026
@adriadam10

Copy link
Copy Markdown
Collaborator

Closing as a duplicate: sceVoiceEnableChat / sceVoiceDisableChat are already implemented on main (d6300dd), with the same behaviour (record the flag, fail before sceVoiceInit) and the debt entry in docs/dev/debt/libSceVoice.md. This PR now conflicts in GuestVoice.cpp and libSceVoice.md and adds nothing over main.

If you want extra test coverage for these calls (e.g. the repeat/toggle rows), feel free to open a small PR on top of current main.

@adriadam10 adriadam10 closed this Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs needs rebase Conflicts with main, rebase needed prx unblocks title Names a title ID on the Unblocks line

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants