Repository navigation
fix(progress_history): label axis dates on calendar days - #6574
Merged
adriadam10 merged 1 commit intoOct 19, 2026
Merged
adriadam10 merged 1 commit into
adriadam10 merged 1 commit into
Conversation
Axis labels and grid lines were drawn only at data points, so a Monday without a commit lost its label. The label loop now walks every calendar day between the first and last point. A test covers a series that skips several Mondays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
I inspected the Windows relinker log for run 38807048211. The failure is in the unrelated |
12 tasks done
11 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
chart()only drew an axis label and grid line at x positions that have a data point, and there is one point per day with commits.labelled()chooses Mondays for spans over 31 days (and the first Monday of each month past 150 days), so any chosen Monday without a commit lost its label. The current Pages chart (2026-08-03 to 2026-10-15) is missing the 08-10, 08-17 and 08-31 labels for that reason. The label loop now walks every calendar day from the first to the last point;px()already takes any day ordinal.Tested
Windows 11, Python 3.12.10. New
test_axis_labels_fall_on_calendar_days_without_commits(a 70-day series with three Mondays missing) fails on main ('>08-10<' not found) and passes with the fix.test_long_series_keeps_the_chart_readablestill gets the same label counts. Alltools/tests/test_*.pypass andpython tools/check_conventions.py --base origin/mainpasses.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code