Repository navigation
fix(libSceNgs2): keep CalcListener basis when front and up are parallel - #6594
Conversation
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
jotitadev
left a comment
There was a problem hiding this comment.
Linux run: head 4a486a7ed merged onto main 5d9dcc42d (clean merge), in one tree with seven other library PRs that share no files with this one. The description lists Windows only.
Machine: Ubuntu 26.04, Intel i7-8700, GCC 15.2, full build, Release, BUILD_TESTING=ON.
ngs2_geompasses, and passes 5/5 with--repeat until-fail:5.- Test only, with
Geom.cppfrommain:ngs2_geomaborts withUnit: invalid argument, which is the original error. So the new parallel front/up case covers the fix. - Non-GPU suite (
ctest -E "^agc|gpu|vulkan|video_out"): no regressions. The only failures arefile_writer_binaryandfile_writer_text, which also fail onmainon this machine.
Written with AI assistance (Claude Code). I ran the builds and tests above on my machine.
|
Windows run: head Machine: Windows 11 Pro 10.0.26200, Intel i5-13450HX, 24 GB RAM, NVIDIA GeForce RTX 3050 6GB Laptop GPU (Windows driver 32.0.16.1742), WinLibs GCC 15.2.0 r7, full build, Release,
Written with AI assistance (Claude Code). I ran the builds and tests above on my machine. |
4a486a7 to
dae7b88
Compare
|
Rebase handoff — rebased onto current Verified on Linux (CachyOS, kernel 7.2.9, GCC 16.2.1, Ninja, Release,
To pick it up: Head is |
|
Dead Cells (PPSA15552) reaches this throw on
AI-assisted (Claude Code). |
PPSA15552 passes matching front/up after a listener move; pick a perpendicular up hint instead of throwing so Dead Cells can keep running. Co-authored-by: Cursor <cursoragent@cursor.com>
dae7b88 to
07d9f40
Compare
|
Dead Cells (PPSA15552): with this change the
AI-assisted (Claude Code). |
|
Checked the new basis construction: with I rebased onto current |
|
Confirmation on plain
|

What
sceNgs2GeomCalcListenerthrewUnit: invalid argumentwhenorient_frontandorient_upwere parallel (zero cross product). PPSA15552 (Dead Cells) hits that after moving the listener withorient_front={0,0,1}andorient_up={0,0,1}.When the right axis vanishes, replace up with
(0,1,0)or(1,0,0)and rebuild the orthonormal basis. Zero-length orientation vectors still throw. Does not implement GeomApply (see #5974).Tested
ngs2_geom_testspassedChecklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)