Repository navigation
test(agc): cover the color to depth format mapping of depth compare copies - #6700
Conversation
…opies Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
@adriadam10 a short request for review of this test-only PR ( AI-assisted (Claude Code). |
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
What
Texture::DepthCopyFormatdecides which guest texture formats a depth-compare sample can be served by copying a pending depth surface (ShaderResources.cpp,depthCopy):R32_SFLOATmaps toD32_SFLOAT,R16_UNORMtoD16_UNORM, every other format toVK_FORMAT_UNDEFINED, which keeps the sample on the guest-memory path.DepthCompareCopyreaches the two mapped formats (R32F and R16 unorm) through whole draws; nothing exercises theUNDEFINEDdefault. AdddepthCopyFormatTeststoagc_driver_graphics_tests: both mappings, andUNDEFINEDforR8G8B8A8_UNORM,R16_SFLOAT,R16_UINT,R32_UINT,D32_SFLOATandUNDEFINED.The expected values are the function's switch. The test does not change behaviour and passes on
main.Tested
Release build, MinGW-w64, Windows 10 (19045),
main5d9dcc42dplus this commit (2aeb06f36).ctest -R '^agc_driver_graphics$': passed (6.9 s). With the 16-bit expectation changed toD32_SFLOATthe same test fails with "a 16-bit unorm color format did not map to the 16-bit unorm depth format", so the new cases run.tools/check_conventions.py --base upstream/main: all checks passed. The new function needs no Vulkan device; the executable ran against the NVIDIA GeForce RTX 4080 SUPER driver. Linux/lavapipe not tested.Checklist
main; no other open PR implements the same tests (no open PR touchesDepthCopyFormat; test(agc): cover the DWORD rounding of guest buffer view ranges #6695 and others edittests/Graphics.cppat other places)NotImplemented_nid_no_patch); no stubs added.mdfiles or images added to the repositoryAI-assisted (Claude Code).
🤖 Generated with Claude Code