Repository navigation
Conversation
Contributor
Author
|
Closing in favor of #6744 after reviewing its updated evidence. The author reproduced the reported failure on unchanged main, showed that 37 of 44 accepted waits lacked a live or pending image for the tested surface, then passed 100/100 fresh Windows GPU runs on the exact committed fix. That is stronger and more specific than my earlier Linux-only build evidence, and the PR isolates the tested surface by address and size. My PR’s diagnosis overlapped; no separate fix is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #6735.
HoldPendingtreated any pending storage image as evidence that the just-submitted store for this surface had executed. Since submissions are asynchronous and earlier fixture cases can leave unrelated images pending, the helper could return before this surface had a live storage image; the subsequentReadImage/FindLivecheck could then race the queue worker. It now waits for pending writes that overlap the surface under test.Tested
python3 tools/check_conventions.py --base upstream/main— passed.git diff --check— passed.agc_driver_store_over_untracked_teststarget built on Linux after temporarily applying the independent missing-templatecompiler fix from fix(shader): qualify dependent member template #6738; that unrelated line was removed before commit.Checklist
main; no other open PR implements the same functions