Repository navigation
fix(agc): cover unaligned guest buffer views - #7001
Merged
oneandonlydean merged 3 commits intoOct 17, 2026
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
11 tasks done
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
Contributor
|
GPU test run for the head 45be3c0 (filling the Tested gap):
Independently reproduced the bug first: the same test binary built on main's formula fails with "a guest buffer view range did not cover the whole view" (I had a parallel fix in #7019, now closed in favour of this one). |
11 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes
GuestBufferMemory::ViewBytesunder-coverage when an off-DWORD adjustment and byte count have remainders whose sum exceeds four. The computed range now rounds the completeadjustment + bytesspan up to a DWORD, while retaining the existing aligned-adjustment behavior. Regression coverage includes byte counts 2, 3, 6, 7 and 4098 with unaligned adjustments.This follow-up is based on xXPBSXx's test commit from #6695, preserved unchanged as the first commit. Depends on: #6695.
Tested
Linux source workspace.
python3 tools/check_conventions.py --base upstream/main --head HEADpassed;git diff --checkpassed; exhaustive formula comparison for byte counts and adjustments 0..63 passed. The AGC CMake test target could not be built because CMake could not find system SDL2 and the pinned SDL2 submodule commit was unavailable from the shallow submodule checkout. No GPU test run.Checklist
main; no other open PR implements the same functions