Repository navigation
fix(agc): keep nonbinding import probes from pinning buffers - #7061
Merged
oneandonlydean merged 1 commit intoOct 17, 2026
Merged
Conversation
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Prevent nonbinding host-import probes from changing the use stamps that protect actual buffer pointers from eviction.
peekImportand a stampingfindImport.HostImportCovers, joined-span endpoint expansion, sparse join-base metadata, and profiling-only import classification.With a two-import budget, a coverage hint or a refused join currently refreshes an otherwise unused import. A later disjoint descriptor then copies because the unused import appears held. The regressions show that the descriptor can instead acquire its complete import while genuinely acquired buffers remain protected.
Related: #6097 fixes the stale covering lookup in
importAllocation. This change addresses other nonbinding callsites and uses the same observational helper split. No stale-import qualification or allocation changes from #6097 are included.Merge order: #5372 changes joined-span policy at the same two endpoint expressions. The overlap check reports that textual conflict, so it is listed as a merge-order dependency below. After #5372 lands, its
!= nullptrendpoint predicates should be retained while usingpeekImportfor both lookups. This PR is independently built and tested on main.Tested
Windows 11 build 26300, MinGW GCC 15.2, Release, publication base
ef674f5af3e4d0fe44fda10e46d36ead2c262c0e, after preserving the original frozen experiment onadb0e7a8cb68232f457c788afa90e53648c0f15f.a coverage hint prevented eviction of an unused import;a failed join endpoint probe prevented eviction of an unused import. The genuine-acquisition control passes on that baseline.agc_driver_graphics_tests: passed, natural exit, 15.640 s after the publication rebase (5.954 s on the original frozen experiment), including existing joined-import and sparse-heap coverage.ANYPS5_REQUIRE_VULKAN=1 APS5_PROFILE_DRAW=1 ANYPS5_NO_SHADER_CACHE=1:agc_driver_host_import_windows_tests,agc_driver_host_import_at_map_tests,agc_driver_bda_device_tests, andagc_driver_host_import_teardown_testsall passed without skips.vkCreateQueryPoolwhen profiling is enabled; the same preparation failure occurs on baseline and candidate. Native profile-enabled gates above passed.python tools/check_conventions.py --base origin/main: passed.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)