Repository navigation
Conversation
…osetta Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The relinker execution checks for
--to-rosettaand AMD64-only conversions are compiled only for x86-64, but the existing macOS relinker matrix builds only the runner's native architecture. Add a macOS x86-64 matrix entry, install Rosetta, and passCMAKE_OSX_ARCHITECTURESthrough CMake so those tests execute on Apple Silicon CI.This is complementary to #3962, which adds x86-64 coverage for register-context and write-watch tests.
Tested
python3 tools/check_conventions.py --base upstream/mainpasses.git diff --check upstream/main...HEADpasses.actionlintin this Linux environment; hosted CI has not reported checks yet.Checklist
main; no open PR implements the relinker x86-64 runner.