Repository navigation
test(agc): give the flip store test the deadline its siblings use - #7774
Merged
oneandonlydean merged 1 commit intoOct 19, 2026
Merged
oneandonlydean merged 1 commit into
oneandonlydean merged 1 commit into
Conversation
agc_driver_flip_stores_small_results waits 2 s for the flip and the stored texels. That window also holds the driver's start and the compute program's compilation at dispatch, so on a loaded host the flip arrives late and the test reports that it did not reach the GPU. Wait 10 s, as the other execution tests do.
12 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
agc_driver_flip_stores_small_resultsfails on a loaded host withAGC graphics: the flip did not reach the GPU. It is an execution test, so the Windows job does not run it (ANYPS5_AGC_EXECUTION_TESTSpicks three), and the Linux job runs it on llvmpipe in 0.1 to 1.1 s; the failure comes up in a full localctest --parallel 4run, where it failed once in 1,593 tests while the AGC execution tests around it compiled their shaders.The test submits one frame and waits 2 s for the flip and the stored texels. That window also holds the driver's start on the first submission and the compute program's compilation at dispatch (
ANYPS5_NO_SHADER_CACHE=1in the test's environment, so it compiles on every run):The other execution tests that wait on a deadline after
Submitgive it 10 s (AliasCopyLabel,PipelinedDispatch,PipelinedDma,PreparedShaders,StoreOverUntracked,UnimportedLabelOrder, among others). This one now waits 10 s as well. The driver is not changed. Test-only.Tested
AMD Ryzen 7 5800X3D (8 cores, 16 threads), NVIDIA GeForce RTX 4080 SUPER, driver 617.42, Windows 11 Pro 26300, WinLibs GCC 15.2.0 r7 (UCRT), Release,
main72a3d9f2a(the test andPacketMemory.cppare the same on currentmainc1ca83479). Each round started 24 copies of the test together, with 16 busy loops in the same session to load the host; the test's own environment (ANYPS5_NO_SHADER_CACHE=1,APS5_NO_PIPELINE_JOURNAL=1, the source root as working directory).mainthe flip did not reach the GPUctest)Revert check: with the small-result store at a flip removed from
PacketMemory.cpp(the callStoreSmallPending("flip")that #4841 added), the test fails 10 of 10 runs witha small image written before a flip did not reach guest memory while the queue kept working, with and without this change.python tools/check_conventions.pyagainstmainpasses.Not checked: Linux and macOS, though the change is platform-independent test code.
Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)