Repository navigation
test(relinker): characterize embedded code data scanning - #7837
Conversation
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
|
Manual review of the overlap report for this PR at I refreshed the eleven flagged PR heads and inspected their changes to the shared CMake/debt files against their respective merge bases. None of these heads contains
Integration note for #6044: our registration uses the current main branch's
|
2cf72de to
3dc2ecb
Compare
fogydes
left a comment
There was a problem hiding this comment.
Reviewed the diff and test fixture:
CodeDataScanningTests.cpp: Provides clear characterization of the relinker's linear instruction scanning across 7 distinct scenarios (contiguous instructions, single-byte padding, trailing padding, inline data bytes resembling valid opcodes, un-bounded jump tables, fallthrough into inline constants, and valid relocations within mixed data).docs/dev/debt/relinker.md: Accurately documents the current linear scanning and heuristic boundary limitations under### Functional.- De-confliction analysis in the discussion thoroughly accounts for all 11 flagged PRs and confirms no semantic collision.
- Zero comments added in code; Conventional Commits title; all checklist items completed.
Ready to merge.
AI-assisted: yes
|
This is the full-suite run after the final rebase that the description says is missing. Head 3dc2ecb was merged into AI-assisted: yes (Claude Code) |
|
Checked the fixture against the scanner API and the |
What
Adds a synthetic characterization test for the scanner limitation reported in #7547. A direct call crosses an unused data gap to a second routine. The fixture checks the current decode rejection for undecodable data, the false-positive rejection for syscall-shaped data, and detection of a real syscall in the called routine beyond the gap. It covers zero, nonzero and above-4-GiB origins, and both SDK-stub trap settings for syscall checks.
This is a test-only contribution with a debt entry. It deliberately records the current failures. Code/data boundary inference remains unimplemented, #7547 remains open, and conversion or execution of the affected title has not been established.
Tested
Windows 11 Enterprise 10.0.26200, Release, WinLibs GCC 15.2.0 r7 (x86_64-ucrt-posix-seh, MinGW-w64 14.0.0), Python 3.11, relinker-only build with BUILD_TESTING=ON.
No title execution, Linux/macOS runtime validation or performance claim.
Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)