Repository navigation
test(libkernel): exercise read-only getdirentries buffers before EOF - #7892
Merged
oneandonlydean merged 1 commit intoOct 19, 2026
Conversation
12 tasks done
valenciana-nc
deleted the
test/getdirentries-readonly-fresh-descriptor
branch
October 19, 2026 17:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Test-only follow-up to #7672, addressing @wachi35676's feedback. That PR merged at
950eeb847while this test improvement was being prepared.CheckReadOnlyDestinationused the descriptor that had just read all entries in its writable control. On unpatched main, the read-onlybufcall therefore returned 0 at EOF instead of exercising the output-buffer access violation.Close that descriptor and open a fresh one before the read-only checks. After the
bufandbaseprefusals, restore permissions and confirm entries remain unread. No runtime code changes.Overlap scan: #6044 relocates this test file as part of test-suite organization; it does not implement this fresh-descriptor check. Whichever change lands second must preserve the test adjustment at its resulting location.
Tested
Windows 11 (26300), WinLibs GCC 15.2.0 r7, Release,
BUILD_TESTING=ON:mainb106f6f8c(the merge of fix(libkernel): refuse read-only guest mappings for getdirentries on Windows #7672).guest_directory,guest_directory_buffer,guest_directory_rewind,guest_directory_close: 4/4 pass.Stdio.cpprestored from pre-fix8982791bc: the improved test segfaults writing to0x200000000during the read-onlybufcall, rather than merely failing at EOF.This test binary is Windows-only. No Linux runtime behaviour changes.
Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)