Skip to content

test(libkernel): exercise read-only getdirentries buffers before EOF - #7892

Merged
oneandonlydean merged 1 commit into
boykopovar:mainfrom
valenciana-nc:test/getdirentries-readonly-fresh-descriptor
Oct 19, 2026
Merged

oneandonlydean merged 1 commit into
boykopovar:mainfrom
valenciana-nc:test/getdirentries-readonly-fresh-descriptor

Conversation

@valenciana-nc

Copy link
Copy Markdown
Contributor

What

Test-only follow-up to #7672, addressing @wachi35676's feedback. That PR merged at 950eeb847 while this test improvement was being prepared.

CheckReadOnlyDestination used the descriptor that had just read all entries in its writable control. On unpatched main, the read-only buf call therefore returned 0 at EOF instead of exercising the output-buffer access violation.

Close that descriptor and open a fresh one before the read-only checks. After the buf and basep refusals, restore permissions and confirm entries remain unread. No runtime code changes.

Overlap scan: #6044 relocates this test file as part of test-suite organization; it does not implement this fresh-descriptor check. Whichever change lands second must preserve the test adjustment at its resulting location.

Tested

Windows 11 (26300), WinLibs GCC 15.2.0 r7, Release, BUILD_TESTING=ON:

This test binary is Windows-only. No Linux runtime behaviour changes.

Checklist

  • Based on current main; no other open PR implements the same functions
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical debt
  • Unimplemented paths throw (NotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file
  • No notes, investigation .md files or images added to the repository (attach them to this PR)
  • New third-party code is a submodule built from source
  • Generic behaviour, not specific to one title
  • Depends on: none
  • Fixes: none
  • Unblocks: none
  • GPUs tested: n/a
  • AI-assisted: yes

@oneandonlydean oneandonlydean self-assigned this Oct 19, 2026
@oneandonlydean
oneandonlydean merged commit b00edd1 into boykopovar:main Oct 19, 2026
10 checks passed
@valenciana-nc
valenciana-nc deleted the test/getdirentries-readonly-fresh-descriptor branch October 19, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants