Skip to content

docs(agc): record the PM4 type-0 packets a submission is rejected for - #7986

Merged
oneandonlydean merged 2 commits into
boykopovar:mainfrom
xXPBSXx:docs/debt-pm4-type0
Oct 20, 2026
Merged

oneandonlydean merged 2 commits into
boykopovar:mainfrom
xXPBSXx:docs/debt-pm4-type0

Conversation

@xXPBSXx

@xXPBSXx xXPBSXx commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

What

Adds a technical-debt entry (gap first): a dword whose packet type is 0, a zero header word included, is rejected with unsupported PM4 packet type (CommandValidation.cpp), so the submission throws. Whether the console's command processor skips or executes such dwords, and what a run of them in front of a REWIND packet means, is unverified; shadPS4 (liverpool.cpp) and KytyPS5 (pm4.cpp) also treat type 0 as unsupported. Evidence: Teardown PPSA15246 on main + #7717, driver failure: AGC driver: unsupported PM4 packet type: header 0x00000000 at DWORD 15 of 6369 (submission at guest 0x2015c5620: NOP 7 dwords, ACQUIRE_MEM 8 dwords, then the zero header); the same stop and the REWIND payload that follows it are described in #7867.

Tested

python tools/check_conventions.py --base upstream/main: all checks passed. Documentation only; no code or test changed. Title run: PPSA15246, Windows 10, NVIDIA GeForce RTX 4080 SUPER, driver 610.74, tree main + #7717 (merge), 34 s until the stop.

Checklist

  • Based on current main; no other open PR implements the same functions
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical debt
  • No notes, investigation .md files or images added to the repository
  • Generic behaviour, not specific to one title
  • Depends on: none
  • Fixes: none
  • Unblocks: none (records an observation; no stop is fixed)
  • GPUs tested: n/a (documentation)
  • AI-assisted: yes

AI-assisted (Claude Code).

🤖 Generated with Claude Code

@xXPBSXx

xXPBSXx commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

Pushed a follow-up commit (docs only, no force) that extends the entry with a description of the zero run measured in a title's submission: it begins with a seven-dword NOP and an eight-dword ACQUIRE_MEM, then 169 dwords of zero headers (dwords 15 to 183), and its packets start at dword 184, as sections separated by zero gaps of 26 to 455 dwords; letting a zero header through only moved the stop to a stale word. The gap-first wording is unchanged, the entry is 912 characters (under the 1000-character debt limit), no title name is added, and python tools/check_conventions.py --base upstream/main passes. The sentence comes from agent B's measurement of the same submission.

AI-assisted (Claude Code).

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.

Pull request Shared files not compared
PR 2434 docs/dev/debt/libSceAgcDriver.md
PR 4448 docs/dev/debt/libSceAgcDriver.md
PR 4449 docs/dev/debt/libSceAgcDriver.md
PR 5058 docs/dev/debt/libSceAgcDriver.md
PR 5499 docs/dev/debt/libSceAgcDriver.md
PR 5925 docs/dev/debt/libSceAgcDriver.md
PR 6146 docs/dev/debt/libSceAgcDriver.md
PR 6194 docs/dev/debt/libSceAgcDriver.md
PR 6223 docs/dev/debt/libSceAgcDriver.md
PR 6273 docs/dev/debt/libSceAgcDriver.md
PR 6280 docs/dev/debt/libSceAgcDriver.md
PR 6300 docs/dev/debt/libSceAgcDriver.md
PR 6412 docs/dev/debt/libSceAgcDriver.md
PR 6481 docs/dev/debt/libSceAgcDriver.md
PR 6548 docs/dev/debt/libSceAgcDriver.md
PR 6549 docs/dev/debt/libSceAgcDriver.md
PR 6636 docs/dev/debt/libSceAgcDriver.md
PR 6683 docs/dev/debt/libSceAgcDriver.md
PR 6727 docs/dev/debt/libSceAgcDriver.md
PR 6808 docs/dev/debt/libSceAgcDriver.md
PR 6867 docs/dev/debt/libSceAgcDriver.md
PR 6868 docs/dev/debt/libSceAgcDriver.md
PR 6926 docs/dev/debt/libSceAgcDriver.md
PR 6946 docs/dev/debt/libSceAgcDriver.md
PR 6947 docs/dev/debt/libSceAgcDriver.md
PR 6977 docs/dev/debt/libSceAgcDriver.md
PR 7085 docs/dev/debt/libSceAgcDriver.md
PR 7256 docs/dev/debt/libSceAgcDriver.md
PR 7446 docs/dev/debt/libSceAgcDriver.md
PR 7449 docs/dev/debt/libSceAgcDriver.md
PR 7505 docs/dev/debt/libSceAgcDriver.md
PR 7604 docs/dev/debt/libSceAgcDriver.md
PR 7618 docs/dev/debt/libSceAgcDriver.md
PR 7642 docs/dev/debt/libSceAgcDriver.md
PR 7844 docs/dev/debt/libSceAgcDriver.md
PR 7862 docs/dev/debt/libSceAgcDriver.md
PR 7927 docs/dev/debt/libSceAgcDriver.md
PR 8014 docs/dev/debt/libSceAgcDriver.md
PR 8099 docs/dev/debt/libSceAgcDriver.md

@github-actions github-actions Bot added the needs rebase Conflicts with main, rebase needed label Oct 19, 2026
xXPBSXx and others added 2 commits October 19, 2026 20:22
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@xXPBSXx
xXPBSXx force-pushed the docs/debt-pm4-type0 branch from fa5af3d to 4e3e810 Compare October 19, 2026 18:24
@xXPBSXx

xXPBSXx commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto main 1e774a3b2 (new head 4e3e810a7, two commits). The conflict was in docs/dev/debt/libSceAgcDriver.md: main now holds the queue 0x20 WAIT_REG_MEM entry at the place where this entry went; both lines are kept, so the diff against main is the one PM4 type-0 packets line (912 characters, under the debt-length limit). python tools/check_conventions.py --base upstream/main passes; documentation only, no code or test changed. Both commits carry the account's noreply address; the previous head fa5af3d21 is kept as tag backup/7986-fa5af3d21 on the fork.

AI-assisted (Claude Code).

@github-actions github-actions Bot removed the needs rebase Conflicts with main, rebase needed label Oct 19, 2026
@blawesom

Copy link
Copy Markdown
Contributor

Rebase handoff — rebased onto current main cleanly (all ten commits, authorship unchanged).

Verified on Linux (CachyOS, kernel 7.2.9, GCC 16.2.1, Ninja, Release, BUILD_TESTING=ON, AMD RX 9070 XT / RADV): builds; conventions pass; full suite green apart from the four known main regressions (#5444 Mesa, #7584 BDA, #7766, #7784), none from this PR.

To pick it up:

git fetch https://github.com/blawesom/AnyPS5 rebase/7986
git checkout <your branch>
git merge --ff-only FETCH_HEAD

Head is 7f6b0ed58.

@github-actions github-actions Bot added the docs label Oct 19, 2026
@oneandonlydean oneandonlydean self-assigned this Oct 20, 2026
@oneandonlydean
oneandonlydean merged commit 32e88ad into boykopovar:main Oct 20, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants