Repository navigation
fix(tools): resolve unscoped registry imports from guest modules - #8093
Merged
oneandonlydean merged 1 commit intoOct 20, 2026
Conversation
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
For registry entries with an empty library name, the Windows loader searches host libraries and bundled guest modules.
import_audit.pyconsidered guest exports only whenlibrary is None, so it could report an available function as absent and identify the wrong startup blocker. Include guest exports for empty-library entries while preserving literal-symbol precedence, NID fallback and named-library lookup.Observed with Call of Duty: Modern Warfare III, PPSA01649/01.055.000: the supplied
libSceAppContent.sprxresolvesSWVxsi-ZBlw,gpGZDB4ZlrIandS5eMvWnbbXg, but the audit reports all three absent. The correction removes those false positives and identifiessceNpAppLauncherInitializeas the first unresolved root import, matching the native log. MW3 still fails before guest entry; this is a diagnostic fix, not a gameplay or performance change.Tested
bf2c63f85: eight new subcases fail before the change and pass after it. They cover sectioned ELF, sectionless SysV/GNU ELF, converted PE, repeated references and genuine missing imports; the unrelated named-provider control remains a failure.6d89a7bd8with all 15 supplied code inputs. Loader logs confirm those three resolve; the runtime hashes and original metadata are unchanged.ghis not authenticated locally). No confirmed overlap; fix(tools): resolve $ORIGIN-prefixed converted module dependencies in import_audit #7454 could not be compared because it conflicts with main. Its patch was reviewed manually: it normalizes$ORIGINpaths and does not change this lookup. fix(tools): recognize guest module identities in import audit #6171 handles module identities; feat: optionally fail import audits on referenced throwing stubs #7440 adds strict stub checking. No dependency on these PRs.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)