[thuanquang]

What

Follow-up to #8262. The relinker's checks on a guest module's output name also report the main executable on the Input: line, because their exceptions carry no input path and the conversion's catch fills in the executable. With --windows and a module named broken é.prx:

FAIL: Unsupported Windows guest filename: broken é.prx.guest.prx
Input: ...\eboot.bin

The three output-name checks in GuestModuleBuilder's per-module loop (unsupported guest filename, unsupported Windows guest filename, conflicting guest output filename) now put the module's path in the exception, as the guest image reader already does. The loop's duplicate-export check gets the same change for consistency, but it cannot be reached: GuestImageReader rejects a duplicate stripped export first, and its error already names the module.

Tested

Windows 11 26200, WinLibs GCC 15.2.0 r7, Release, BUILD_TESTING=ON.

• conversion_diagnostics: with --windows and with --windows --to-intel, a new case converts an executable with a well-formed guest module named broken é.prx (the helper's existing name). It requires Unsupported Windows guest filename and exactly one Input: line naming the module.
• Red on main 1edbe4b5e with only the test change: both new cases fail, and their Input: line names eboot.bin.
• Green: conversion_diagnostics passes 3 of 3. With every relinker test executable rebuilt, all 151 tests under core/relinker pass.
• It merges cleanly with fix(relinker): name the guest module when its syscall scan fails #8262, which adds a case to the same test, and with the open relinker PRs that change GuestModuleBuilder.cpp (fix(relinker): resume scans after undecodable bytes between PS4 unwind functions #7660, fix(relinker): share Windows --module-dir modules between executables #7450, fix(relinker): infer guest dependencies from referenced imports #6903, fix(relinker): run a guest DT_INIT of 0 as the module initializer #6684) or the syscall scanner (fix(relinker): resync the syscall scan past undecodable data regions #8042, fix(relinker): mask embedded data tables in inter-FDE gaps #8076).
• On the title from Gang Beasts (CUSA04865) #7941 (@ntamas94, Gang Beasts CUSA04865, relinker --windows ... --module-dir Media/Modules eboot.bin with main + fix(relinker): name the guest module when its syscall scan fails #8262 + fix(relinker): name the guest module in its output filename errors #8270): the syscall stop now reports Input: ...\Media\Modules\MonoAssembliesPS4.prx instead of eboot.bin.
• python tools/check_conventions.py --base origin/main with this title and body passes.

Checklist

• Based on current main; no other open PR implements the same functions
• One topic per PR; follow-ups go in a new PR
• No comments in code except technical debt
• Unimplemented paths throw (NotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file
• No notes, investigation .md files or images added to the repository (attach them to this PR)
• New third-party code is a submodule built from source
• Generic behaviour, not specific to one title
• Depends on: none
• Fixes: none
• Unblocks: none
• GPUs tested: n/a
• AI-assisted: yes (Claude Code)

🤖 Generated with Claude Code

[github-actions]

Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.

Pull request	Shared files not compared
PR 6977	core/relinker/relinker/src/guest/GuestModuleBuilder.cpp
PR 8076	core/relinker/relinker/src/guest/GuestModuleBuilder.cpp

[wachi35676]

Verdict: confirm. Tested at 99ffb6a75, merged onto main 02fb1ce53, relinker-only Release:

• Windows 11 Home 10.0.26300, WinLibs GCC 15.2.0 r7: ctest 221/221.
• WSL Ubuntu 24.04, GCC 13.3: ctest 226/226, so the Linux build and conversion_diagnostics pass too.
• Negative control: this PR's test_conversion_diagnostics.py against main's relinker fails at 1-module-name, the --windows case.
• The PS5 homebrew relinks (PPSA99005, PPSA47402, PPSA99581, PPSA99995 with 16 Wine modules; Windows, macOS and Linux targets) are byte-identical to main.

AI-assisted: yes (Claude Code); results above were run on this machine.