Repository navigation
fix(tests): skip the 1023-byte guest path check on macOS hosts - #8284
Merged
oneandonlydean merged 1 commit intoOct 23, 2026
Merged
Conversation
macOS fails a host path of 1024 bytes or more with ENAMETOOLONG, and the host form of a guest path is the root directory followed by the guest path, so a guest path of 1023 bytes, which FreeBSD accepts, fails there under any root directory. guest_path_name_length skips that check on macOS, and a debt entry for guest path names gives the macOS limit.
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
This was referenced Oct 20, 2026
Contributor
|
Windows run of 381c3b9 merged onto Built |
12 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
guest_path_name_length(#8164) fails on macOS at its check that a guest path of exactly 1023 bytes is not too long. The guest check passes it; the host does not. macOS fails a host path of 1024 bytes or more withENAMETOOLONG, and the host form of a guest path is the root directory followed by the guest path, so a 1023-byte guest path is always longer than that there. In the test the root is the 73-byte build directory, so the host path has 1097 bytes. Part of the macOS series announced on #1 (#1 (comment)).Tested
macOS 26.5.1, Apple M5 Max, Apple clang 21, x86-64 build under Rosetta 2. The libraries do not link on macOS without the rest of the macOS series, so the run is on
main3fd1cc3 with the series (ci/macos-series-2on my fork), #8279, the open macOS fixes #7524 and #7937, and three changes from #7332.guest_path_name_lengthaborts without this PR with "a path of exactly 1023 bytes must not be too long (errno 63)" and passes with it.staton macOS: an absolute path of 1023 bytes givesENOENT, one of 1024 bytesENAMETOOLONG.guest_working_directory,guest_path_caseandguest_directorypass.guest_filesystemfails on macOS with and without this PR; it is among the macOS failures feat(libkernel): direct memory mappings on macOS hosts #7631 lists, from before fix(libc): fail an oversized guest path name with ENAMETOOLONG #8164.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)