Repository navigation
feat(libSceAgcDriver): implement diagnostic fallbacks - #9086
Conversation
Progress report (a6fc8a4 → 36a7a09)📈 System libraries: 43.26% (+0.01%, +2 implemented functions) ✅ 2 implemented
⚪ 2 behaviourally empty (constant return or throw)
|
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
|
Manual review of the overlap report:
The bot could not complete those comparisons because of the base conflicts, so this is a manual review. GitHub currently reports this PR mergeable. No unrelated PRs were changed. |
fma-rc
left a comment
fma-rc
left a comment
There was a problem hiding this comment.
Checked against the PS5 12.70 libSceAgcDriver module: sceAgcDriverGetCoredumpAddress returns the driver's coredump area pointer, which stays null until that area is allocated, and sceAgcDriverSetTargetRingForDiag logs and returns 0x8A6D0001. Both match what this PR does. Built on Linux together with main and your other open PRs; agc_driver_unsupported_diagnostics passes.
|
Relevant: the conflict with #7965 in docs/dev/debt/libSceAgcDriver.md (lines 11–12) is confirmed. I’ve updated this PR’s Depends on entry and asked #7965’s author to confirm the landing order; the report shows no same-export overlap. The other entries are skipped comparisons, so I’ll continue reviewing those shared files manually. |
|
Follow-up to my note above: the remaining skipped comparisons have now been reviewed. The CMake warnings do not add a competing registration for �gc_driver_unsupported_diagnostics_tests; the related edits are in other build/test sections. The debt-file warnings describe other AGC routines, while this PR's entries concern only sceAgcDriverGetCoredumpAddress and sceAgcDriverSetTargetRingForDiag. My earlier review summary is at #9086 (comment). #7965 remains the one confirmed adjacent debt-list conflict, and I have requested landing-order confirmation there. |
540123b to
fa58d52
Compare
b0ed47b to
abce3c5
Compare
abce3c5 to
36a7a09
Compare
|
I refreshed the live overlap/NID audit against |
What
Implement two diagnostic exports using behavior observed in the retail PS5
libSceAgcDriver.sprx:sceAgcDriverGetCoredumpAddressreturns the shared coredump-area pointer, which is null when no area is allocated. AnyPS5 currently disables coredump mode and allocates no such area, so the export returns null.sceAgcDriverSetTargetRingForDiagreturns0x8A6D0001(DRIVER_FEATURE_UNAVAILABLE), matching the retail export's observed response.A focused test covers both responses. The technical-debt entry records that coredump-area support and the retail diagnostic log are not implemented. No scanner, progress, UI, history, or percentage behavior changes are included.
Evidence: disassembly of the retail PS5
libSceAgcDriver.sprx; the coredump-mode and allocation state in AnyPS5.Tested
agc_driver_unsupported_diagnostics_teststarget and ranctest -R agc_driver_unsupported_diagnosticssuccessfully.python tools/check_conventions.py --base upstream/mainpassed.docs/dev/debt/libSceAgcDriver.md(main lines 11–12). A pairwisegit merge-treecheck confirms the conflict. The bot reports no same-export overlap. I manually checked the shared CMake warnings; they do not register or changeagc_driver_unsupported_diagnostics_tests.git diff --checkpassed.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)