Repository navigation
Conversation
Contributor
|
Linux data point for
|
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
Contributor
12 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
For Windows output,
import_audit.pylowercases module names after attempting case-sensitive suffix removal. A suppliedsdk-shipping.prxtherefore does not match a registry dependency namedSDK-Shipping.DEBUG_PRX. The audit reports an absent import, a missing library and a loader stop even though the guest module is present. Uppercase or mixed-case suffixes on the supplied filename cause the same mismatch.Apply the existing Windows case normalization before removing
.prx,.sprx,.suprxor.debug_prx. This matches the order already used by the relinker'sModuleStem. ELF-output matching remains case-sensitive, and reports retain the original registry library names.Tested
Windows, Python 3.14.7. Base
maincecb540a63f6, candidatee3110be3a373. Synthetic PE system libraries and ELF guest modules; no title execution, native relinker build or GPU test is claimed.--strict-providers: main exits 1, classifies the import as absent and reportsSDK-Shipping.DEBUG_PRXmissing; the candidate exits 0, classifies it as a guest module and reports no missing library or unresolved stop. Both retain one import reference.python -m unittest tools.tests.test_import_audit: 124 tests run, 121 passed, 3 skipped for platform/filesystem conditions.python tools/check_test_registration.py --scripts: 170 scripts registered. Conventions andgit diff --checkpass.python tools/pr_overlap.py --branch fix/audit-windows-module-extension-case --repo boykopovar/AnyPS5 --jobs 8: completed with no confirmed overlap. It could not automatically compare fix(tools): recognize guest module identities in import audit #6171 (35bf15c510cb) and fix(tools): resolve $ORIGIN-prefixed converted module dependencies in import_audit #7454 (11840ad87c40) because those PRs already conflict with main. Their complete tool/test diffs were reviewed manually: they add declared module identities and$ORIGINhandling, respectively; neither changesmodule_stemor the insertion point of these tests. This is a manual assessment for those two PRs, not an automated clean-merge claim.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)