Repository navigation
docs: describe the converted module output the relinker prints - #9488
dantdmdarealguy wants to merge 1 commit into
Conversation
MarcZX10
left a comment
There was a problem hiding this comment.
Reviewed the two documentation updates against the current relinker output and runtime layout implementation. The CLI now prints a converted-module count and a layout tree under app0/, and no longer emits the old per-module “Guest module:” line. The replacements accurately describe where the generated .guest.prx files are written and preserve the requirement to keep the original module alongside them. The PR changes only those two stale instructions, follows the template, and reports focused documentation and Windows runtime checks. The conventions, intake, eligibility and label checks pass; executable build jobs were skipped, which is appropriate for this documentation-only diff.
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
MarcZX10
left a comment
There was a problem hiding this comment.
Rechecked the two changed instructions against the relinker output described in the PR and the reported Windows runtime-layout reproduction. Both now point readers to the generated .guest.prx files in app0/ and the printed layout tree; GAME_TESTING.md also preserves the instruction to keep the original .prx. The reported focused documentation checks pass. Hosted eligibility, intake, conventions and labels pass; build/relinker jobs are skipped for this documentation-only diff. I did not run local tests.
MarcZX10
left a comment
There was a problem hiding this comment.
The two documentation replacements match the current relinker output described in the PR, and the focused documentation/runtime tests plus policy checks are reported passing. The branch is still based on a6dcea9, while upstream main is now ab347d1; although these two documentation files have no intervening upstream changes and GitHub reports the PR mergeable, please update the branch/checklist to current main before merging. I could not independently retrieve the path-filtered diffs for the nine uncomparable PRs listed in the overlap warning in this pass; the PR’s exact-string manual check is useful, so please refresh the overlap check on the updated base and retain the documented finding that those diffs do not mention the removed Guest module: output. I did not run local tests.
5dd96b3 to
2fe7ca0
Compare
|
Rebased onto current |
The relinker stopped printing a 'Guest module:' line for each converted module in 56c2a53; it reports 'Converted modules: N' and lists the .guest.prx files under app0/ in its runtime layout tree. GAME_TESTING.md and USAGE.md still told readers to use the files printed as 'Guest module:'.
2fe7ca0 to
0c5e45e
Compare
|
Rebased onto |
What
Since 56c2a53 (
fix(relinker): redraw console progress and format runtime layout as a tree, 2026-10-13), the relinker no longer prints aGuest module: <path>line for each converted bundled module. It printsConverted modules: Nand then lists each.guest.prxunderapp0/in itsArrange the files like thistree (core/relinker/main.cppL438-452,core/relinker/cli/include/RuntimeLayout.hpp). It writes each converted module intoapp0/beside the output executable, keeping the module's own folder (GuestModuleBuilder.cppL292).Two guides still tell the reader to use the files "printed as
Guest module:", a line that no longer appears in the output:docs/dev/GAME_TESTING.mdL15 (Before a run)docs/user/USAGE.mdL175 (Runtime layout)Both sentences now point at the
.guest.prxfiles that the relinker writes intoapp0/and lists in the tree it prints. The rest of each paragraph is unchanged. That includes keeping the original.prxand the error 193 note.Tested
Windows 11 Pro, Intel Core i9-14900K, 128 GB RAM, NVIDIA GeForce RTX 5080 (driver 32.0.16.1742), WinLibs GCC 15.2.0. Release build of
main5a79f2645plus--target libs relinker, rebased onto that commit.tools/unwrap_self.py, was relinked withrelinker --windows --registry source/eboot.elf run/app.exe. The run ends with:Guest moduleline (grep -c= 0), and the file was written torun/app0/sce_module/libc.prx.guest.prx. Laid out that way, with the originallibc.prxkept beside it, ScreenTester5 starts (Selected GPU name=NVIDIA GeForce RTX 5080), opens its window and exits with 0 when the window is closed after 25 s.git grep -n '"Guest module: "' -- corefinds nothing on5a79f2645. 56c2a53 removed the print (git log -S).git grep "Guest module:" -- docsfinds 2 lines onmain(GAME_TESTING.md:15,USAGE.md:175) and none with this change.python tools/check_conventions.py --base origin/main:All conventions checks passed.ctest -R "^(patched_libraries|conventions_doc_links|test_registration)$": 3/3 passed (367 patched libraries loaded, 0 failed).python tools/pr_overlap.py --branchon the rebased branch: no overlap with the PRs it could compare. It could not compare 9 PRs that conflict withmain(feat(aot): consolidate native ARM64 compiler, runtime and consumers #5021, perf(agc): build the pipelines of a submission ahead on a compile pool #5925, fix(tools): recognize guest module identities in import audit #6171, feat(agc): select Vulkan devices by driver name #6788, perf(recompiler): keep runtime-specialized shader modules in the shader disk cache #6924, feat(agc): look up table images at run time through a device image table on the GPU heap (APS5_GPU_PATH) #7642, fix(agc): reclaim idle images safely during cache creation #7800, fix(relinker): rewrite XSAVEOPT to XSAVE under --to-rosetta #7918, feat(relinker): trace function imports on macOS #9408), all ondocs/user/USAGE.md. I fetched each head (pull/<n>/head) and diffed it against its merge base withmainfordocs/user/USAGE.mdanddocs/dev/GAME_TESTING.md. None of these diffs containsGuest module(orguest.prx), and none touchesGAME_TESTING.md.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)