Repository navigation
Conversation
MarcZX10
left a comment
There was a problem hiding this comment.
The implementation matches the documented FreeBSD 11.4 behavior for SO_TYPE and SO_ACCEPTCONN: it reads the tracked guest socket type/listen state, returns the flag bit, and truncates to the caller's output length. The author-reported Windows test covers IPv4/IPv6, UDP/TCP, listener/accepted state, short buffers and invalid descriptors. Current eligibility, conventions, intake, labels, and report checks pass; hosted product/relinker jobs are skipped. I did not run a local test. I also checked that this PR and #9523 merge together cleanly.
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
MarcZX10
left a comment
There was a problem hiding this comment.
The implementation review and author-reported Windows test remain as noted in my earlier review, but the current overlap report changes the merge-readiness assessment. It now lists shared , , and debt-file comparisons with #9523, #9542, #9543 and #9544, and shared paths with #9506; older conflicted-base comparisons remain unresolved as well. My earlier clean merge check with #9523 is not enough to clear the refreshed report. Please compare the exact hunks, coordinate landing order with affected authors where the rule applies, record any prerequisites in , and update the overlap report after resolving/rebasing. I’m requesting changes for the repository’s overlap/coordination requirement; I found no new behavior defect in this diff. Current policy checks pass; product jobs are skipped, and I did not rerun local tests.
MarcZX10
left a comment
There was a problem hiding this comment.
The implementation review and author-reported Windows test remain as noted in my earlier review, but the current overlap report changes the merge-readiness assessment. It now lists shared CMakeLists.txt, Export.cpp, and debt-file comparisons with #9523, #9542, #9543 and #9544, and shared paths with #9506; older conflicted-base comparisons remain unresolved as well. My earlier clean merge check with #9523 is not enough to clear the refreshed report. Please compare the exact hunks, coordinate landing order with affected authors where the rule applies, record any prerequisites in the Depends on checklist, and update the overlap report after resolving/rebasing. I’m requesting changes for the repository’s overlap/coordination requirement; I found no new behavior defect in this diff. Current policy checks pass; product jobs are skipped, and I did not rerun local tests.
|
Current-head recheck: sync is 1 ahead / 119 behind today’s |
|
@MarcZX10 refreshed this branch onto main |
What
Implement
SO_TYPEandSO_ACCEPTCONNqueries insceNetGetsockoptusing the guest socket type and listening state. Readback follows FreeBSD 11.4 sogetopt: listening returns bit2, and short output buffers are truncated. Unverified console and pointer behavior remain in library debt.Tested
Windows 11 x86-64, WinLibs MinGW-w64 GCC 15.2.0-r7, Ninja, Release. Head
a2cd79cd2bincludes main097a9514a0.guest_net_socket_state: 1/1 pass, with no skips.a23f8fc9fbis clean; runtime results remain tied to the included base097a9514a0.Merge order remains #9523 → #9542 → #9515 → #9578 and #9525 → #9543 → #9930 → #8686; #9931 follows #9542. #9930 and #9931 may land in either order after their prerequisites. The #9932/#9948 author agreed to follow #9930/#9931 and preserve both debt entries. Keep every getter path and test registration during integration.
The #6044 test-reorganization and #5836 peer-socket order proposals still await their authors. If #6044 lands first, move these tests to tests/networking and use add_library_test(networking ...). Manual checks of #7201/#8658/#9733 find separate resolver or send/host-platform paths; their existing base conflicts remain. No duplicated socket-option implementation was found in those inspected changes.
Earlier combined integration results cover eight network tests on Windows and WSL2 at tree c9c1293. Those results are separate from this revision's focused run. No fresh Linux/macOS, full hosted product build, title or console run is claimed.
Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)