WIP: Branch for testing API review #480
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaskaris
changed the title
andreaskaris
force-pushed
the
conditions-api-changes
branch
15 times, most recently
from
b26b2a7 to
09760ca
Compare
Implements status conditions and component status tracking for the Config custom resource to provide visibility into the reconciliation state of managed components (ConfigMap, DaemonSets, CSIDriver, SCC). - Add ConfigComponentStatuses type with status for each component - Implement Progressing and Available conditions following Kubernetes conventions - Add event recording for status changes - Update controller with status subresource RBAC permissions - Add test coverage for all status states - Integrate status checks into lifecycle tests The status system tracks individual component readiness and sets overall conditions to indicate when the Config is progressing or fully available. Signed-off-by: Andreas Karis <[email protected]>
Signed-off-by: Andreas Karis <[email protected]>
andreaskaris
force-pushed
the
conditions-api-changes
branch
9 times, most recently
from
c0630da to
8d2cd36
Compare
Add checkResourcesInDesiredState function to verify that the default health probe port (8175) is correctly applied to bpfman and metrics proxy DaemonSets when not explicitly set in the Config spec. This test ensures the default value handling introduced in the API standards compliance changes works correctly at runtime. Signed-off-by: Andreas Karis <[email protected]>
andreaskaris
force-pushed
the
conditions-api-changes
branch
from
f07437a to
1b3b8ad
Compare
andreaskaris
force-pushed
the
conditions-api-changes
branch
6 times, most recently
from
11aff3f to
909959a
Compare
Make the following changes to align with OpenShift API standards: - Update field documentation to use lowercase descriptions per OpenShift style guidelines - Add explicit field descriptions for metadata, spec, and status on Config type - Remove redundant +kubebuilder:validation:Required tags (implied by +required marker) - Add validation constraints (MinLength, MaxLength) to string fields - Change HealthProbePort type from int to int32 for consistency - Make HealthProbePort optional, with default value 8175 applied in controller instead of API layer - Add enum validation for AgentSpec.LogLevel - Use omitzero JSON tag for required Spec field - Add MaxItems validation for status Conditions array - Add documentation for ConfigComponentStatus constants Signed-off-by: Andreas Karis <[email protected]>
andreaskaris
force-pushed
the
conditions-api-changes
branch
from
909959a to
6f44f20
Compare
API review: remove BpfApplicationState GetClientObject Method GetClientObject is not used and removing it removes the dependency on sigs.k8s.io/controller-runtime/pkg/client Signed-off-by: Andreas Karis <[email protected]>
andreaskaris
force-pushed
the
conditions-api-changes
branch
2 times, most recently
from
e02a213 to
1add523
Compare
This commit updates the v1alpha1 API types to follow OpenShift API standards by: - Adding `omitempty` JSON tags to all optional and status fields - Using `omitzero` for required spec fields to ensure they're validated - Adding field-level documentation comments for metadata, spec, and status - Adding validation constraints (MaxItems, MinLength, MaxLength) to arrays and strings - Setting proper list types (atomic, map) for arrays - Reordering Status fields to place Conditions first per convention - Improving consistency in field documentation across all types Signed-off-by: Andreas Karis <[email protected]>
andreaskaris
force-pushed
the
conditions-api-changes
branch
from
1add523 to
85d1f01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just to run CI and to keep API review changes and actual code in sync
API review is here: openshift/api#2521
Conventions: https://github.com/openshift/enhancements/blob/master/dev-guide/api-conventions.md