Skip to content

Use enums instead of defines for parameters #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use enums instead of defines for parameters #21

wants to merge 1 commit into from

Conversation

dnrce
Copy link

@dnrce dnrce commented Sep 2, 2014

Avoids name conflicts.

@dnrce
Copy link
Author

dnrce commented Sep 2, 2014

@Lauszus does this look better than #20?

@dnrce dnrce changed the title Use enums instead of defines Use enums instead of defines for parameters Sep 2, 2014
@Lauszus
Copy link

Lauszus commented Sep 2, 2014

Yeah that looks better to me ;)

@dnrce
Copy link
Author

dnrce commented Mar 20, 2016

Rebased. @br3ttb, any thoughts here?

@dnrce
Copy link
Author

dnrce commented Mar 20, 2016

FYI this is coming from my non-fork forked Particle adaptation: https://github.com/dnrce/Particle-PID

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@vsirin vsirin vsirin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dnrce @Lauszus @vsirin