Skip to content

fix: don't overwrite authorization header #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0x416e746f6e wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: don't overwrite authorization header #160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions transport.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,19 +126,22 @@ func (t *Transport) RoundTrip(req *http.Request) (*http.Response, error) {
}()
}

token, err := t.Token(req.Context())
if err != nil {
return nil, err
}

creq := cloneRequest(req) // per RoundTripper contract
creq.Header.Set("Authorization", "token "+token)

if creq.Header.Get("Authorization") == "" { // We only add an "Authorization" header to avoid overwriting the expected behavior.
token, err := t.Token(req.Context())
if err != nil {
return nil, err
}
creq.Header.Set("Authorization", "token "+token)
}
if creq.Header.Get("Accept") == "" { // We only add an "Accept" header to avoid overwriting the expected behavior.
creq.Header.Add("Accept", acceptHeader)
}

reqBodyClosed = true // req.Body is assumed to be closed by the tr RoundTripper.
resp, err := t.tr.RoundTrip(creq)

return resp, err
}

Expand Down