Add tracing library for ADK #37
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a library to help trace Google's Agent Development Kit. The built in tracing is not consistent, google/adk-go#479, so implement our own tracing and also skip exporting the built in traces to Braintrust. Since ADK already has callbacks at every stage, it should be easy to add tracing, we just have to do some manual bookkeeping in order to set the parent and child relationships correctly because ADK is not doing that natively by passing around contexts in that way. Also added an example script based on the adk library's examples, though I modified it a bit because the base example never exits cleanly, which breaks some tracing. The new version uses ctrl+c to cleanly exit. Add traceadk Drop native ADK spans Fix agent/model tracing
clutchski
reviewed
Feb 2, 2026
clutchski
reviewed
Feb 2, 2026
clutchski
reviewed
Feb 2, 2026
clutchski
reviewed
Feb 2, 2026
clutchski
reviewed
Feb 2, 2026
| ) | ||
|
|
||
| // Set span attributes | ||
| span.SetAttributes(attribute.String("agent.name", ctx.AgentName())) |
Contributor
There was a problem hiding this comment.
i think the metadata should be prefixed by adk.*
Author
There was a problem hiding this comment.
Will update, I assume that I should leave the standard attributes in the model/tool calls the same, like "tool.description" or "gen_ai.prompt_tokens"? Or should I change those too?
clutchski
reviewed
Feb 2, 2026
clutchski
reviewed
Feb 2, 2026
clutchski
reviewed
Feb 2, 2026
| } | ||
|
|
||
| // Delete all spans from this session | ||
| c.deleteAllSessionSpans(ctx.SessionID()) |
Contributor
There was a problem hiding this comment.
is there any risk of stomping parallel sub agents or anything like that?
Author
There was a problem hiding this comment.
good question, let me read up a bit and also try out parallel agents to confirm
clutchski
reviewed
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a library to help trace Google's Agent Development Kit. The built in tracing is not consistent, google/adk-go#479, so implement our own tracing and also skip exporting the built in traces to Braintrust. Since ADK already has callbacks at every stage, it should be easy to add tracing, we just have to do some manual bookkeeping in order to set the parent and child relationships correctly because ADK is not doing that natively by passing around contexts in that way.
Also added an example script based on the adk library's examples, though I modified it a bit because the base example never exits cleanly, which breaks some tracing. The new version uses ctrl+c to cleanly exit.