-
Notifications
You must be signed in to change notification settings - Fork 0
Add highest and lowest dependency testing in CI #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the CI workflow to test the AlphaFlow package against both the highest and lowest compatible dependency versions, improving confidence that the package works across its supported dependency range.
Key Changes:
- Adds a matrix dimension for dependency resolution strategies (highest/lowest) to the test job
- Updates the test job name to include the resolution strategy being tested
- Modifies the dependency installation command to use the resolution strategy from the matrix
.github/workflows/ci.yml
Outdated
| fail-fast: false | ||
| matrix: | ||
| python-version: ["3.10", "3.11", "3.12", "3.13", "3.14"] | ||
| resolution: [highest, lowest] |
Copilot
AI
Dec 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value 'lowest' may not be a valid resolution strategy for uv. Based on uv's documentation, the valid values for the --resolution flag are 'highest' and 'lowest-direct', not 'lowest'. Consider changing this to 'lowest-direct' to ensure the CI correctly tests with the lowest compatible dependency versions.
| resolution: [highest, lowest] | |
| resolution: [highest, lowest-direct] |
3a055ee to
9a57c5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
.github/workflows/ci.yml
Outdated
| run: uv sync --dev --resolution=${{ matrix.resolution }} | ||
| - name: Run ruff linting | ||
| run: uv run ruff check | ||
| run: uv run --no-sync ruff check |
Copilot
AI
Dec 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra space detected in the ruff check command. There are two spaces between "run" and "--no-sync" instead of one.
| run: uv run --no-sync ruff check | |
| run: uv run --no-sync ruff check |
9a57c5a to
d8613e2
Compare
No description provided.