Skip to content

Conversation

@brandonschabell
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings December 24, 2025 04:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the CI workflow to test the AlphaFlow package against both the highest and lowest compatible dependency versions, improving confidence that the package works across its supported dependency range.

Key Changes:

  • Adds a matrix dimension for dependency resolution strategies (highest/lowest) to the test job
  • Updates the test job name to include the resolution strategy being tested
  • Modifies the dependency installation command to use the resolution strategy from the matrix

fail-fast: false
matrix:
python-version: ["3.10", "3.11", "3.12", "3.13", "3.14"]
resolution: [highest, lowest]
Copy link

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value 'lowest' may not be a valid resolution strategy for uv. Based on uv's documentation, the valid values for the --resolution flag are 'highest' and 'lowest-direct', not 'lowest'. Consider changing this to 'lowest-direct' to ensure the CI correctly tests with the lowest compatible dependency versions.

Suggested change
resolution: [highest, lowest]
resolution: [highest, lowest-direct]

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

run: uv sync --dev --resolution=${{ matrix.resolution }}
- name: Run ruff linting
run: uv run ruff check
run: uv run --no-sync ruff check
Copy link

Copilot AI Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space detected in the ruff check command. There are two spaces between "run" and "--no-sync" instead of one.

Suggested change
run: uv run --no-sync ruff check
run: uv run --no-sync ruff check

Copilot uses AI. Check for mistakes.
@brandonschabell brandonschabell merged commit 566d794 into main Dec 26, 2025
12 checks passed
@brandonschabell brandonschabell deleted the dependency-versions branch December 26, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants