Prevent spaces from being double encoded #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a double-encoding bug where spaces encoded as %20 in URLs were being incorrectly re-encoded to %2520. The fix ensures that URL path components are properly decoded before being encoded to prevent this issue.
- Fixed double-encoding of percent-encoded spaces by decoding path components before re-encoding
- Added comprehensive test coverage for various positions of
%20encoding in URL paths - Verified that actual unencoded spaces are still properly encoded to
%20
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| urlpath/init.py | Modified the path property to decode parts before encoding to prevent double-encoding |
| tests/test_url.py | Added test cases to verify the fix for percent-encoded spaces and ensure proper encoding behavior |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent spaces from being double encoded