Fixed colon in filename bug #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where colons in filenames were incorrectly treated as scheme separators during URL parsing, causing URLs like http://www.example.com/abc:def.html to be truncated. The fix introduces a custom parsing method that handles query and fragment components without relying on urlsplit, which treats colons as scheme indicators.
Key changes:
- Added
_name_partsproperty that manually parses the filename into path, query, and fragment components - Updated
name,query,fragment, andtrailing_sepproperties to use the new parser instead ofurlsplit - Added comprehensive test coverage for colons in filenames with various combinations of query and fragment components
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| urlpath/init.py | Implements custom URL component parsing to avoid colon-as-scheme issue |
| tests/test_url.py | Adds test cases verifying colon handling in filenames works correctly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed colon in filename bug