Added test for jmespath #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds test coverage for the get_json() method's JMESPath filtering functionality, which allows filtering JSON responses using JMESPath query expressions.
Key changes:
- Added comprehensive test for
get_json()method with JMESPath query filtering - Updated CHANGELOG.md to document recent refactoring and improvements
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test_url.py | Added new test function with mock HTTP response to verify JMESPath filtering works with string queries, compiled expressions, and query parameters |
| CHANGELOG.md | Updated changelog entries to reflect recent codebase refactoring and modularization changes |
| import urllib.parse | ||
| from pathlib import PurePosixPath | ||
| from typing import Any, cast | ||
| from unittest.mock import Mock |
There was a problem hiding this comment.
Import Mock from unittest.mock at the top level but use patch from within the test function. For consistency, move the patch import to the top level imports alongside Mock.
Suggested change
| from unittest.mock import Mock | |
| from unittest.mock import Mock, patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.