Skip to content

Fix Flushing of InfoFile #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prikhi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Flushing of InfoFile #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions src/FileUtils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@

import pickle
import os, stat
import tempfile
import shutil

def file_exists(path):
"Returns true if path refers to any existing object (including a dead symlink)"
Expand Down Expand Up @@ -88,15 +90,16 @@ def flush(self, verify=True):

if self.filename and self.items is not None and self.dirty:

tempname = temp_filename_for(self.filename)
with open(tempname, 'wb') as fl:
with tempfile.NamedTemporaryFile('wb', delete_on_close=False) as fl:
pickle.dump(self.items, fl)
if verify:
with open(tempname, 'rb') as fl:
items = pickle.load(fl)
assert items == self.items
os.rename(tempname, self.filename)
self.dirty = False
fl.close()

if verify:
with open(fl.name, 'rb') as ro_fl:
items = pickle.load(ro_fl)
assert items == self.items
shutil.copy(fl.name, self.filename)
self.dirty = False

return True
else:
Expand Down