Skip to content

add config for absolute minimum utxo amount #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

JssDWt
Copy link
Collaborator

@JssDWt JssDWt commented Mar 31, 2025

No description provided.

@JssDWt JssDWt requested a review from Copilot March 31, 2025 18:52
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new configuration parameter, min_utxo_amount_sat, to enforce an absolute minimum UTXO amount for swaps. Key changes include:

  • Adding a new field to the configuration in public_server.rs.
  • Propagating the new parameter through the SwapParameters construction.
  • Introducing a command-line argument with documentation and default value in main.rs.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
swapd/src/public_server.rs Added a new config field and updated parameter propagation logic.
swapd/src/main.rs Introduced a new command-line argument with corresponding docs.
Comments suppressed due to low confidence (1)

swapd/src/main.rs:527

  • Ensure that the behavior of the min_utxo_amount_sat parameter is covered by tests, validating that swaps use at least the absolute minimum value.
min_utxo_amount_sat: args.min_utxo_amount_sat,

@JssDWt JssDWt requested review from roeierez and yaslama March 31, 2025 19:07
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JssDWt JssDWt merged commit bd574bf into main Apr 1, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants