Skip to content

fix(BREV-2100): Provide estimateddeploytime for launchpad instances #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(BREV-2100): Provide estimateddeploytime for launchpad instances #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions v1/providers/launchpad/instancetype.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"fmt"
"strconv"
"strings"
"time"

"github.com/alecthomas/units"
"github.com/bojanz/currency"
Expand All @@ -16,6 +17,10 @@ import (

const (
brevDGXCWorkshopID = "brev-dgxc"
dmzCloud = "dmz"

defaultEstimatedDeployTime = 15 * time.Minute
dmzEstimatedDeployTime = 1 * time.Minute
)

func (c *LaunchpadClient) GetInstanceTypes(ctx context.Context, args v1.GetInstanceTypeArgs) ([]v1.InstanceType, error) {
Expand Down Expand Up @@ -200,6 +205,13 @@ func launchpadInstanceTypeToInstanceType(launchpadInstanceType openapi.InstanceT
}
typeName := makeInstanceTypeName(info)

var estimatedDeployTime time.Duration
if launchpadInstanceType.Cloud == dmzCloud {
estimatedDeployTime = dmzEstimatedDeployTime
} else {
estimatedDeployTime = defaultEstimatedDeployTime
}

it := &v1.InstanceType{
Type: typeName,
VCPU: launchpadInstanceType.Cpu,
Expand All @@ -214,6 +226,7 @@ func launchpadInstanceTypeToInstanceType(launchpadInstanceType openapi.InstanceT
Provider: CloudProviderID,
Cloud: launchpadInstanceType.Cloud,
ReservedInstancePoolID: launchpadWorkshopIDToReservedInstancePoolID(info.workshopID),
EstimatedDeployTime: &estimatedDeployTime,
}

// Make the instance type ID
Expand Down
Loading