chacha: Clarify the dispatching to assembly implementations. #2238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2238 +/- ##
=======================================
Coverage 96.96% 96.96%
=======================================
Files 166 167 +1
Lines 20565 20573 +8
Branches 463 463
=======================================
+ Hits 19940 19948 +8
Misses 517 517
Partials 108 108 ☔ View full report in Codecov by Sentry. |
briansmith
force-pushed
the
b/chacha-ffi
branch
from
f2eb637 to
16b877f
Compare
Clarify that there are 4 different functions, one for each architecture, which have different capabilities w.r.t. overlapping input/output. we plan to extend this to support all the details of the dispatching that is currently within each assembly implementation of `ChaCha20_ctr32` when that dispatching logic is moved to Rust.
briansmith
force-pushed
the
b/chacha-ffi
branch
from
16b877f to
97f22ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify that there are 4 different functions, one for each architecture, which have different capabilities w.r.t. overlapping input/output.
we plan to extend this to support all the details of the dispatching that is currently within each assembly implementation of
ChaCha20_ctr32when that dispatching logic is moved to Rust.