Repository navigation
Conversation
mikz
force-pushed
the
bridgetown-2-support
branch
from
October 17, 2025 10:00
54cee40 to
0c24f70
Compare
It now properly depends on action_view gem, which it uses.
mikz
marked this pull request as ready for review
January 9, 2026 10:27
mikz
commented
Jan 9, 2026
| require "view_component" | ||
|
|
||
| # Create basic Rails namespace when in Bridgetown-only context | ||
| # Remove this when https://github.com/ViewComponent/view_component/pull/2462 is merged and released. |
Author
There was a problem hiding this comment.
It is merged, but not yet released as of ViewComponents 4.1.1
Author
|
@jaredcwhite I think this should be good to release, but I'd wait for feedback from @ksol as he already identified one issue in #9 (comment) |
This was referenced Jan 9, 2026
jaredcwhite
self-requested a review
January 10, 2026 06:42
|
I'll try and take a look this week, but no promises as I've started a new job. Don't wait on me if I take too long :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aim of this PR is to bring bridgetown-view-component to the latest version of bridgetown (2.0) and view_component (4.0).
TODO
How to try this
For anyone wanting to try this on a project and give feedback.
Add this to your bridgetown Gemfile: