#183 Fix "Connection refused" with docker-machine #184
Conversation
Fix for "Connection refused" running docker-osx-dev with docker-machine #183
| # Support < 0.4.1 and >= 0.5.1 | ||
| DOCKER_HOST_USER=$(inspect_docker_machine "{{.Driver.SSHUser}}" || inspect_docker_machine "{{.Driver.Driver.SSHUser}}") | ||
| DOCKER_HOST_IP=$(inspect_docker_machine "{{.Driver.IPAddress}}" || inspect_docker_machine "{{.Driver.Driver.IPAddress}}") | ||
| DOCKER_HOST_IP=$(docker-machine ip) |
There was a problem hiding this comment.
The ip command takes the machine name as an arg. Shouldn't you use $DOCKER_MACHINE_NAME as a parameter here?
There was a problem hiding this comment.
It fallbacks to "default" if none is give: https://github.com/docker/machine/blob/5b9663f8960af73c048e14cc60566ae487c07728/commands/commands.go#L102 but to me it seems that it would be best to supply the $DOCKER_MACHINE_NAME in here so this would work for people using a different machine name :) So $(docker-machine ip "$DOCKER_MACHINE")
There was a problem hiding this comment.
@rkuzsma Are you still working on this?
|
Thanks for the PR. Just one comment. If you make a change, make sure to post a comment, as GitHub doesn't send notifications for new code pushes to a PR. |
3 participants
Fix for "Connection refused" running docker-osx-dev with docker-machine
#183