fix: max spotter tx msg len for cellular #104
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
The Sofar Ocean server backend now supports the cellular-only queue for
spotter_tx_data! This PR updates the checks for max payload length, since it varies depending on the telemetry channel. For Iridium SBD, the max payload length is 311 as before, but the cellular payload max is 1000 bytes.Also, this PR fixes a memory leak. Previously, when payloads were > 311 bytes, we would allocate the buffer and return an error without freeing the buffer.How does it make Bristlemouth better?
Enables Bristlemouth developers to manage telemetry costs by selectively using a cellular-only message queue on Spotter. These messages will be dropped and never sent if a cellular connection is not available.
Where should reviewers focus?
Please review all changes, less than 100 lines. I only modified one function and expanded its associated unit tests.
Checklist