Skip to content

Conversation

@matt001k
Copy link
Contributor

@matt001k matt001k commented Nov 6, 2025

What changed?

  • Changed size of typedef buffer AanderaaConductivityString
  • CMD_INTERVAL is reported as a float value on the 5990 not uint

How does it make Bristlemouth better?

Fixes bugs that address the Salinity app

Where should reviewers focus?

When reading the interval from the 5990 it is reported in exponential format:

command: Get Interval
command response: Interval      5990    75      1.000000E+02
command response: #
sendCommand err: 0

When examining this value as an int, it looks like the reading is 1 second rather than 100.
Casting the value to a float addresses this.

The string length for AanderaaConductivityString was too small for one specific parameter:

#define CMD_ENABLE_DERIVEDPARAMETERS "Enable Derived Parameters"

This breached the 32 char limit. Increasing this to 64 will address any immediate issues.

Checklist

  • Add or update unit tests for changed code
  • Ensure all submodules up to date. If this PR relies on changes in submodules, merge those PRs first, then point this PR at/after the merge commit
  • Ensure code is formatted correctly with clang-format. If there are large formatting changes, they should happen in a separate whitespace-only commit on this PR after all approvals.

- Too small of a buffer for AanderaaConductivityString
- CMD_INTERVAL is reported as a float value on the 5990
@matt001k matt001k changed the title Minor bug fixes to address: Minor bug fixes to address in Salinity app Nov 6, 2025
@matt001k matt001k requested a review from victorsowa12 November 6, 2025 22:32
@matt001k matt001k added the bug Something isn't working label Nov 6, 2025
@matt001k matt001k self-assigned this Nov 6, 2025
@matt001k matt001k marked this pull request as ready for review November 6, 2025 22:43
@matt001k matt001k merged commit a9a3e0d into develop Nov 6, 2025
1 check passed
@matt001k matt001k deleted the fix/aanderaa_salinity_5990_configs branch November 6, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants