Feature/2025 lc stdev #363
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithm. Added new vals to tx msg
| //If load cell read fails | ||
| else { | ||
| missed_reading_counter ++; // to track at the end | ||
| reading_attempts_counter++; //This still updates so we send our message on time. We do not interate successful_reading_count. |
Collaborator
There was a problem hiding this comment.
we could increment this outside of the if/else since it is incremented in both cases.
victorsowa12
approved these changes
Nov 22, 2025
Collaborator
victorsowa12
left a comment
victorsowa12
left a comment
There was a problem hiding this comment.
Looks good to me! Had a small optimization suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Restructured and mostly rewrote the loadCellSample.cpp app.
-Added running variance calculation and standard deviation reporting to remote messages.
-Added missed/successful/attempted readings counting. N for stats is now successful readings, not reading attempts.
-Created new format for remote LC message that fits with ME team needs.
Also some smaller things: Fixed some out of order checks vs measurements, changed some misleading names, deleted unused defines and variables.
Code has been tested on a loadcell and the remote-reported standard deviation matches one calculated after the fact with SD data.
How does it make Bristlemouth better?
-new features (stdev, reading counts)
-much more intelligible
Where should reviewers focus?
Checklist