Fix Salinity App Spam To Log File #364
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Moved Spotter SD card log statement to a location where it will not be spamming the Spotter file system.
How does it make Bristlemouth better?
Users would have unnecessary log statements filling up their SD card while the Salinity sensor is powered on.
Where should reviewers focus?
This was writing logs to a log file at an interval of 10ms but not the console, so it was easy to slip by.
Testing with this fix has had expected results!
Checklist