Skip to content

Conversation

@matt001k
Copy link
Contributor

@matt001k matt001k commented Nov 21, 2025

What changed?

Moved Spotter SD card log statement to a location where it will not be spamming the Spotter file system.

How does it make Bristlemouth better?

Users would have unnecessary log statements filling up their SD card while the Salinity sensor is powered on.

Where should reviewers focus?

This was writing logs to a log file at an interval of 10ms but not the console, so it was easy to slip by.
Testing with this fix has had expected results!

Checklist

  • Add or update unit tests for changed code
  • Ensure all submodules up to date. If this PR relies on changes in submodules, merge those PRs first, then point this PR at/after the merge commit
  • Ensure code is formatted correctly with clang-format. If there are large formatting changes, they should happen in a separate whitespace-only commit on this PR after all approvals.

@matt001k matt001k marked this pull request as ready for review November 21, 2025 20:15
@matt001k matt001k changed the title Fix Salinity App Spam To Console Fix Salinity App Spam To Log File Nov 21, 2025
@matt001k matt001k merged commit dcb9626 into develop Nov 21, 2025
1 check passed
@matt001k matt001k deleted the fix/calibration_spam branch November 21, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants