Update Circuit Python Bm_Serial Script #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
towynlin
reviewed
Aug 26, 2025
circuitpython/bm_serial.py
Outdated
Comment on lines
90
to
91
| for sub_cb in self.sub_cbs: | ||
| sub_cb(node_id, type, version, topic_len, topic, data_len, data) |
Collaborator
There was a problem hiding this comment.
this looks like it runs each message through every sub_cb. We should document that so that we know to make sure the message info is checked within the sub_cb and rejected if not appropriate. Alternatively we could track the sub_cb <-> topic so we only call the sub_cb that is appropriate to the message.
Contributor
Author
There was a problem hiding this comment.
Update with new logic to only call the subbed callback associated with that topic.
victorsowa12
approved these changes
Sep 3, 2025
Collaborator
victorsowa12
left a comment
victorsowa12
left a comment
There was a problem hiding this comment.
Looks good to me! I only had a small suggestion for providing more info on how to use the raw-messages api
towynlin
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Python script for serial communications.
Allows subscribing to topics, and handling received data from another serial device.