Update dockers for BenchmarkVCFs #229
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks, I was just running BenchmarkVCFs myself and noticed the dockers were a bit outdated when I was setting it up. In particular, there's an old ugly
vcfeval:v1.1-tmpdocker that is no longer necessary due to RTG formally releasing a new version back in May. I decided to go ahead and bump a bunch of other versions associated with the pipeline since I was rebuilding dockers.WARNING: This PR is not ready to merge until someone in hydro.gen does the following:
BCFTools,Python-Data-SlimandVCFEvalDockerfiles, do the following:us.gcr.io/broad-dsde-methods/bcftools:v1.4,us.gcr.io/broad-dsde-methods/python-data-slim:1.1, andus.gcr.io/broad-dsde-methods/vcfeval_docker:v1.2respectively). I kept the mistaken convention on not having a "v" for versioning the python-data-slim docker that happened for some reason, but do whatever you like there. Also at some point the Dockerfile for that one and README became out of sync so this should fix that as well.After that it should be good to go.