Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do not merge] Imputation beagle with max retries #1506

Draft
wants to merge 69 commits into
base: TSPS-183_mma_beagle_imputation_hg38
Choose a base branch
from

Conversation

mmorgantaylor
Copy link
Member

Description

Give your PR a concise yet descriptive title.
Please explain the changes you made here.
Explain the motivation for making this change. What existing problem does the pull request solve?
Mention any issues fixed, addressed, or otherwise related to this pull request, including issue numbers or hard links for issues in other repos.
You can delete these instructions once you have written your PR description.


Checklist

If you can answer "yes" to the following items, please add a checkmark next to the appropriate checklist item(s) and notify our WARP team by tagging @broadinstitute/warp-admins in a comment on this PR.

  • Did you add inputs, outputs, or tasks to a workflow?
  • Did you modify, delete or move: file paths, file names, input names, output names, or task names?
  • If you made a changelog update, did you update the pipeline version number?

mmorgantaylor and others added 26 commits February 13, 2025 16:40
*pre splitting and prechunking beagle imputation inputs to lower log numbers and storage account egress

---------

Co-authored-by: Jose Soto <[email protected]>
…istic (#1285)

* remove multi sample vcf index workflow input and add it to the PreSplitVcf task.
add seed number so that beagle is always deterministic. add comment to cpu input for PhaseAndImputeBeagle task

* change output_callset_name to output_base_name and remove optional outputs

* change n_failed_chunks ticket to an int

---------

Co-authored-by: Jose Soto <[email protected]>
* clean up wdl with stuff from TSPS-241

* try to make fail fast work with double nested scatters

---------

Co-authored-by: Jose Soto <[email protected]>
…ng imputation against it (#1296)

* add optional error count override for testing

* rename reference base prefix variable and make it more user friendly

---------

Co-authored-by: Jose Soto <[email protected]>
* try auto specifying chr at end of basename

* both tasks

* add liftovervcfs to dockstore

* allow specifying max mem
* try creating bed files

* try again

* try again again

* a different thing

* use bedtools and bed ref panel files

* oops update the correct task

* fix

* use the right freaking file name

* remove comment
* add array imputation quota consumed wdl

* add changelogs for imputation array related workflows

---------

Co-authored-by: Jose Soto <[email protected]>
* changes to help beagle imputation wdl run on a 400k sample reference panel

---------

Co-authored-by: Jose Soto <[email protected]>

* remove create imputation ref panel beagle wdl and changelog

* PR feedback

---------

Co-authored-by: Jose Soto <[email protected]>
Co-authored-by: M. Morgan Aster <[email protected]>
…nel (#1468)

* remove tasks for recovering variants not in the reference panel and separate out beagle tasks from imputation tasks

* remove prechunk wdl and references to it
remove "Beagle" from task names in BeagleTasks.wdl

---------

Co-authored-by: Jose Soto <[email protected]>
@dsde-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/TSPS-183_mma_beagle_imputation_hg38':
Imputation.changelog.md has not been changed and needs to be updated
ImputationBeagle.changelog.md has not been changed and needs to be updated
ArrayImputationQuotaConsumed.changelog.md has not been changed and needs to be updated
BroadInternalImputation.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

@mmorgantaylor mmorgantaylor force-pushed the TSPS-183_mma_beagle_imputation_hg38 branch 2 times, most recently from 0a302fe to 6eb5bfc Compare February 19, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants