fix: route indoor cameras on HomeBase through correct livestream path#830
Closed
lenoxys wants to merge 3 commits into
Closed
fix: route indoor cameras on HomeBase through correct livestream path#830lenoxys wants to merge 3 commits into
lenoxys wants to merge 3 commits into
Conversation
5f9b6f9 to
00964c8
Compare
Contributor
Author
|
Fixed the prettier formatting check. I originally wrote the condition multi-line for readability: (
(
device.isIndoorPTCameraE30() ||
device.isIndoorCameraBase()
) && this.isDeviceControlledByHomeBase()
)Prettier collapsed it to a single line. Not as readable IMO but matches the project style. |
This was referenced Mar 16, 2026
Contributor
Author
Collaborator
|
need to fix the conflict |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Indoor cameras (INDOOR_PT_CAMERA_E30 / type 105, INDOOR_CAMERA / type 30) connected through a HomeBase (e.g. HB3) fail to start livestream. The
startLivestream()method falls through to Branch (3) instead of Branch (1) which has the correct payload for HomeBase-connected devices.Fix
INDOOR_PT_CAMERA_E30andINDOOR_CAMERAon HomeBase into Branch (1) — same payload as outdoor pan-and-tilt camerasAdditional cleanup
INDOOR_PT_CAMERA_E30entries toDeviceCommandsandStationCommandsmapsisIndoorPTCameraE30(),isIndoorCameraBase(), andisFloodLightT8424()device detection methods (static + instance)FLOODLIGHT_CAMERA_8424condition in Branch (2) and replace rawDeviceTypechecks with method callsTested devices
Supersedes #721
This PR supersedes #721, which only added pan/tilt/preset commands to
SOLO_CAMERA_E30DeviceCommands(6 lines, untested). This PR covers the same command map additions plus fixes the actual livestream routing, addsStationCommandsentries, device detection methods, and has been tested on 4 physical devices. #721 can be closed.