Hack around to allow HA users to change the Eufy-Security-client github - to allow users to test unreleased builds to confirm support works or not#33
Conversation
* Update nl.yaml Updated translation: Changed the Danish text to Dutch for the 'ipv4first' label (name and description). * Discord link in root README. * Deployment doc link. * Discord link in add-on readme. * Deployment doc. * Update 1.9.3 (bropat#31) --------- Co-authored-by: phoenix-blue <phoenix-blue@users.noreply.github.com> Co-authored-by: ChayoteJarocho <77412126+ChayoteJarocho@users.noreply.github.com>
…e build configuration - Move existing files to eufy-security-ws-customrepo directory - Update build.yaml to support custom eufy-security-client branches - Add documentation for custom repository usage - Maintain all existing functionality while adding customization capability
|
Here is the draft @max246 |
Thank you for this! I haven't been able to control the light on a Floodlight E30 (T8426) since I got it last year. I have many different eufy camera's with all the lights in HA Automations but that was the only floodlight I couldn't control. Your eufy-security-ws-customrepo fixed that. Thanks again! I'm happy to test anything you need if I have the camera you're looking at. |
Glad to hear it’s been useful! I was surprised nothing like this existed once I understood how HA eufy-security works. After seeing how @max246 added device support for one of my cameras, I learnt from that and built this so I could pull changes from custom repos without waiting for them to go live. Then I forked the eufy-client it self, added support for other cameras I had myself, and threw in a few tweaks for fun 😆. If you left build.yaml as-is, it’s building from my forked development repo for eufy-client. Hopefully, the official client will include my merges soon so it works on the default one too. |
I didn't change the repo in build.yaml as I had seen the changes I was looking for (T8426) looked like they had been added at some point (maybe in develop) so I thought I'd give it a try just the way you had it and sure enough it worked 😆 I've wondered about a custom addon to choose a different repo before, but never dug in enough to learn how to do it so when I saw yours I jumped right on to give it a try. Thanks again! |
|
I believe we can integrate this into the main container, rather than having to different ones unless you are worried about conflicting or security reason |
@max246 That would be ideal — I don't think there are conflicts or security concerns, but I'm not sure how to implement it. In HACS, if users pull from the repository, it will pull the repo link and add the addon, which rebuilds in the background once they press install. I believe there's no way to force a re-build in HA UI - perhaps an option in the configuration? With a custom addon, however, the user can manually press re-build after editing the build.yaml, which then rebuilds based on changes. So, I couldn't find any other way to do it besides a custom addon. |
|
Added this on the docker version bropat/eufy-security-ws#470 |
|
Was talking with @fuatakgun and we believe is safer to keep it separate as you did, but trying to strip to the minium. I will have a look more later |
|
@MELSAID888 I believe we can actually have your way as separate addon to ensure we dont compromise the main build. Can you check the removed stuff and we can move forward with this PR |
| @@ -1,24 +0,0 @@ | |||
| { | |||
| @@ -1,2 +0,0 @@ | |||
| ko_fi: bropat | |||
| @@ -1,97 +0,0 @@ | |||
| name: Bug report | |||
| @@ -1 +0,0 @@ | |||
| blank_issues_enabled: false | |||
| @@ -1,27 +0,0 @@ | |||
| name: "Publish" | |||
| @@ -1,19 +0,0 @@ | |||
| { | |||
| @@ -0,0 +1 @@ | |||
| .Oldbutworking/ | |||
| @@ -1,20 +0,0 @@ | |||
| ARG BUILD_FROM | |||
| @@ -1,5 +0,0 @@ | |||
| { | |||
|
@MELSAID888 I have made a new way for this, I have merged it and you can see in the doc how to install it. Please let me know if everything is ok and we can close this PR. Thank you for your help, your work helped to guide us to the right direction! |
Created this - quick hack - to allow users to get a custom eufy-security-client
Steps is to copy the folder to the HA custom addon - edit the build.yaml with the git repo they want to build on and then it appears in HA custom addons - install and done. If you want to change the build - just edit build.yaml - overwrite it in the custom addon directory in HA, and go to the custom addon and press re-build. Unfortunately rebuild button only appears in HA - if its custom addon. Doesn't show if you pull directly from github - but feel free to poke around.