fix: keep typer from printing locals on crash#163
Merged
Conversation
otherwise XNAT / Brown passwords will be saved in sbatch log files
mirestrepo
approved these changes
Jul 30, 2025
mirestrepo
left a comment
mirestrepo
left a comment
Contributor
There was a problem hiding this comment.
I think this is good solution for now but I'll make an issue to revisit
| from xnat_tools.xnat_utils import establish_connection, get_project_subject_session | ||
|
|
||
| app = typer.Typer() | ||
| app = typer.Typer(pretty_exceptions_show_locals=False) |
Contributor
There was a problem hiding this comment.
Bring back printing of variables during exceptions in the future by obsfuscating the password. We can do that by resetting the value of the variable, hashing it, and also using tokens
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
otherwise XNAT / Brown passwords will be saved in sbatch log files