Repository navigation
Bump remaining vulnerable dependencies - #15
Merged
Merged
Conversation
Clears the fixable open Dependabot alerts across all three scanned manifests: - rust quinn-proto 0.11.14 -> 0.11.15 (GHSA-4w2j-m93h-cj5j) - rust serde_with 3.17.0 -> 3.21.0 (GHSA-7gcf-g7xr-8hxj) - rust tar 0.4.44 -> 0.4.46 in tools/argument-comment-lint (CVE-2026-33055, CVE-2026-33056, GHSA-3pv8-6f4r-ffg2) - pip datamodel-code-generator 0.31.2 -> 0.64.0 in sdk/python (CVE-2026-54621, -54653, -54654, -54690, -54691, -55389, -55391, -55415, -55403) The datamodel-code-generator jump changes codegen behavior, so the bump carries two update_sdk_artifacts.py fixes plus regenerated artifacts: - Generate against --target-python-version 3.10 to match the package's declared requires-python; 0.64 otherwise emits 3.11-only StrEnum. - Strip titles from single-value string-literal subschemas before codegen. 0.64 with --use-title-as-name turns every titled subschema into its own named RootModel class, which would have wrapped 233 discriminator fields that should stay inline Literal[...]s (breaking payload.type == "..." comparisons for SDK consumers). The _set_discriminator_titles prepass is dropped: the runtime schema already carries these titles, so adding them was a no-op, and titles on inline literals are now actively harmful. The regenerated v2_all.py has no class additions or removals; the diff is title metadata dropped from Literal fields plus 0.64 formatting cleanup (no redundant pass/model_config on RootModels, list -> list[Any]). MODULE.bazel.lock repinned via bazel mod deps --lockfile_mode=update. Not addressed here: hickory-proto, which needs the rama 0.3.0 migration (both advisories are already documented exceptions in deny.toml), and the low-severity lru 0.12.5 that comes in via the pinned ratatui fork. Verified: cargo check --workspace --all-targets, cargo deny check advisories/bans/licenses, the MODULE.bazel.lock check script, and sdk/python ruff + pytest (119 passed, including contract regeneration against the new generator).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the fixable open Dependabot alerts across all three scanned manifests (14 of the 17 currently open). The remaining three — hickory-proto (high + medium) and the low-severity
lru0.12.5 — need the rama 0.3.0 migration and a ratatui fork update respectively, and are tracked separately.Bumps
quinn-protocodex-rs/Cargo.lockserde_withcodex-rs/Cargo.toml+ locktartools/argument-comment-lint/Cargo.lockdatamodel-code-generatorsdk/python/pyproject.toml+uv.lockThe
taralerts survived #13 because they live in the separatetools/argument-comment-lintlockfile, not the workspace one.MODULE.bazel.lockis repinned viabazel mod deps --lockfile_mode=update(both crate universes feed it).The datamodel-code-generator jump
sdk/pythonCI regenerates the checked-inv2_all.pyand asserts it is unchanged, and 0.64.0 changes codegen behavior, so the bump carries twoupdate_sdk_artifacts.pyfixes plus the regenerated artifact:--target-python-version 3.10to match the package's declaredrequires-python >= 3.10. 0.64 with the previous3.11target emitsStrEnum, which doesn't exist on 3.10.ApiKeyAccountType), and 0.64 with--use-title-as-nameturns every titled subschema into its own namedRootModelclass. Without the strip, 233 discriminator fields that should stay inlineLiteral[...]s get wrapped, breakingpayload.type == "apiKey"-style comparisons for SDK consumers. The old_set_discriminator_titlesprepass is removed: the runtime schema already carries those titles, so adding them was a no-op, and titles on inline literals are now actively harmful.With both fixes the regenerated
v2_all.pyhas no class additions or removals. The diff is title metadata dropped fromLiteralfields plus 0.64 formatting cleanup (no redundantpass/model_configon RootModels,list→list[Any]).Verification
cargo check --workspace --all-targets— cleancargo deny check advisories bans licenses— all passscripts/check-module-bazel-lock.sh— passessdk/python:ruff check,ruff format --check,pytest— 119 passed, including the contract test that regenerates all artifacts against the new generatorSummary by cubic
Bumps
quinn-proto,serde_with,tar, anddatamodel-code-generatorto clear 14 of the 17 open Dependabot alerts across thecodex-rs,tools/argument-comment-lint, andsdk/pythonmanifests. The remaininghickory-protoandlrualerts need the rama 0.3.0 migration and a ratatui fork update respectively.Migration
datamodel-code-generatorjumps from 0.31.2 to 0.64.0, which changes codegen output.update_sdk_artifacts.pynow targets Python 3.10 and strips titles from inline string-literal subschemas, keeping 233 discriminator fields asLiteral[...]s instead ofRootModelclasses.v2_all.pyhas no class additions or removals, only title metadata removal and formatting cleanup.Written for commit 89d892e. Summary will update on new commits.