-
Notifications
You must be signed in to change notification settings - Fork 16
feat: add retry button to view page on failure #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add a retry button to the RunResultDialog when a scheduled task fails. The button uses the same logic as the Test button to re-run the task.
|
Thank you for your contribution! Before we can merge this PR, we need you to sign our Contributor License Agreement. To sign the CLA, please add a comment to this PR with the following text: You only need to sign once. After signing, this check will pass automatically. Troubleshooting
|
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Greptile OverviewGreptile SummaryThis PR adds a retry button to the RunResultDialog component that appears when a scheduled task fails. The implementation follows a clean approach: Key Changes:
Implementation Details:
Minor Consideration:
The code is well-structured and follows existing patterns in the codebase. Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant RunResultDialog
participant ScheduledTasksPage
participant scheduleStorage
participant scheduleMessages
Note over User,scheduleMessages: User Views Failed Task Run
User->>ScheduledTasksPage: Click to view failed run
ScheduledTasksPage->>ScheduledTasksPage: setViewingRun(run)
ScheduledTasksPage->>RunResultDialog: open dialog with run data
RunResultDialog->>User: Display failed status & error
Note over User,scheduleMessages: User Clicks Retry Button
User->>RunResultDialog: Click Retry button
RunResultDialog->>RunResultDialog: handleRetry()
RunResultDialog->>ScheduledTasksPage: onRetry() callback
ScheduledTasksPage->>ScheduledTasksPage: handleRun(viewingRun.jobId)
ScheduledTasksPage->>scheduleStorage: runJob(jobId)
scheduleStorage->>scheduleMessages: sendScheduleMessage('runScheduledJob')
scheduleMessages-->>scheduleStorage: job execution initiated
scheduleStorage-->>ScheduledTasksPage: job running
RunResultDialog->>ScheduledTasksPage: onOpenChange(false)
ScheduledTasksPage->>ScheduledTasksPage: setViewingRun(null)
RunResultDialog->>User: Dialog closes
|
|
@claude I want to add retry button on the scheduled task runs shown in the new tab page as well. Help implement that logic and create a commit on this prt |
|
Claude finished @felarof99's task in 1m 14s —— View job Completed: Retry button added to new tab page
SummarySuccessfully added retry button functionality to the new tab page's scheduled task runs. The implementation follows the same pattern used in Changes made to
The retry button will now appear in the new tab page when viewing failed scheduled task runs, using the same UI and behavior as the options page implementation. Note: I was unable to run the linter (bun run lint) as it requires approval, but the changes follow the existing code patterns in the file. | |
- Import SCHEDULED_TASK_TESTED_EVENT and runJob hook - Add handleRetry function to trigger job retry with analytics tracking - Pass onRetry callback to RunResultDialog component - Follows same pattern as ScheduledTasksPage implementation Co-authored-by: Felarof <felarof99@users.noreply.github.com>
Add a retry button to the RunResultDialog when a scheduled task fails. The button uses the same logic as the Test button to re-run the task.