Skip to content

fix: typecheck issue #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shivammittal274 merged 1 commit into from
Jan 22, 2026
Merged

fix: typecheck issue #269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/server/src/tools/cdp-based/pages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export const closePage = defineTool({
try {
await context.closePage(request.params.pageIdx)
} catch (err) {
if (err.message === ERRORS.CLOSE_PAGE) {
if (err instanceof Error && err.message === ERRORS.CLOSE_PAGE) {
response.appendResponseLine(err.message)
} else {
throw err
Expand Down Expand Up @@ -207,7 +207,7 @@ export const handleDialog = defineTool({
await dialog.accept(request.params.promptText)
} catch (err) {
// Likely already handled by the user outside of MCP.
logger.error(err)
logger.error(err instanceof Error ? err.message : String(err))
}
response.appendResponseLine('Successfully accepted the dialog')
break
Expand All @@ -217,7 +217,7 @@ export const handleDialog = defineTool({
await dialog.dismiss()
} catch (err) {
// Likely already handled.
logger.error(err)
logger.error(err instanceof Error ? err.message : String(err))
}
response.appendResponseLine('Successfully dismissed the dialog')
break
Expand Down